As before, I've attached a patch that fixes several aspects of field management:

  • Added unlimited cardinality to the audio field.
  • Added checks for pre-existing fields and field instances. Now, when uninstalling the NPR Story module, the user will be required to review the fields in use.
  • Integrated npr_fields into npr_story as they are too closely related to be separated, especially because the custom field created by npr_fields (the npr_audio field) will only ever be used for the NPR Story content type.

This patch addresses the following now-closed issues:

CommentFileSizeAuthor
npr_audio.patch21 KBmusicalvegan0

Comments

crookednumber’s picture

crookednumber commented
Assigned: musicalvegan0 » Unassigned
Status: Needs review » Closed (duplicate)

@musicalvegan0

Thanks so much for your contributions! I in no way want to dampen your enthusiasm here, but I should note that rolling multiple tickets -- even if they seem quite similar -- into a single patch is generally frowned upon. It could very well be that the maintainer(s) don't want to commit all these changes (and/or not in such a particular way), it's harder to rollback parts of the patch, etc. The preferred MO is definitely small, discrete self-contained patches. Yeah, it's definitely more of a PITA, but it pays off in the long run.

webchick had a great -- though comical and somewhat hyperbolic -- illustration here: http://webchick.net/please-stop-eating-baby-kittens

Again, thanks so much for your contributions!

Closing the this one and addressing in the smaller tix.