When I insert a video link from YouTube with the Video Filter Button in CKEditor, I get the following message:

"Strict warning: Only variables should be passed by reference in video_filter_dashboard_page() (line 387 of ...\sites\all\modules\video_filter\video_filter.module)."

Line 387 is the following:

print theme('video_filter_dashboard', array('form' => render(drupal_get_form('_video_filter_form'))));

I only have this problem on one site, on the other it never occured.

#3 strict-warning-message-1662746-3.patch472 bytesbtopro


I am getting the same message...I think render requires a variable, so if you split it to lines as follows the message goes away:

$form = drupal_get_form('_video_filter_form');
print theme('video_filter_dashboard', array('form' => render($form)));

Status:Active» Closed (fixed)

Thanks, the module still works and the message doesn't appear anymore.
Setting status to closed (fixed).

Category:support» bug
Status:Closed (fixed)» Needs review
new472 bytes

Writing about a solution in a thread and marking it fixed without a patch seems a poor way of handling a current error. I'm still reproducing this in the latest version of drupal and latest version of module. Here's a patch of the solution above, which does work just think it should make it into the module.

Status:Needs review» Reviewed & tested by the community

clean patch fixes bug, please include in next release.
Thank you!

Version:7.x-3.0» 7.x-3.1
Status:Reviewed & tested by the community» Active

Patch provided on comment #3 was not included in further releases.
So, the strict warning always appear on 3.1 on line 435 (same file). Comment #1 still works on this line.

Priority:Normal» Major
Status:Active» Reviewed & tested by the community

switching status and priority hoping for commit

Version:7.x-3.1» 7.x-3.x-dev

Patch fixes strict warning for me as well. Still applies to dev version.
Only difference in the patch is that the line number increased by one.