These two from Steven Jones might be nice in integrate. I spoke with him about this in Munich.

Remaining tasks

  • Move hosting_backup_queue.drush.inc to the provision_site_backup_manager

Done:

  • Check the gc queue for relevant issues
  • Check the hosting_backup_queue queue for relevant issues
  • Documentation from the gc project page?
  • Update the gc project page to reference this project
  • Documentation from the hosting_backup_queue project page?
  • Update the hosting_backup_queue project page to reference this project

Comments

helmo’s picture

helmo commented

He now has access

helmo’s picture

helmo commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Assigned: Unassigned » steven jones
Status: Needs work » Needs review

I've finally found some time for this...

hosting_backup_gc is now part of the 6.x-2.x branch.

Please review and test

RunePhilosof’s picture

RunePhilosof commented

You need to rename the schema function.

It must be called modulename_schema, so that would be hosting_site_backup_manager_schema().

RunePhilosof’s picture

RunePhilosof commented
Status: Needs review » Needs work
omega8cc’s picture

omega8cc commented

Patch is submitted for review (tested and works fine): #2003904: Issue #1999728 by RunePhilosof - Fix integration with hosting_backup_gc code - otherwise required table is never created

helmo’s picture

helmo commented

Merged, thanks.

I've updated the summary with some remaining tasks.

helmo’s picture

helmo commented

I noticed that the spin-off provision_site_backup_manager did not have a d.o project...
https://github.com/omega8cc/provision_site_backup_manager
But you probably weren't finished clearing out that repo of the non-provision stuff.

It's now created: https://drupal.org/project/provision_site_backup_manager

Steven Jones and omega8cc are added as maintainer.

I'll update the remaining tasks...

helmo’s picture

helmo commented
Issue summary: View changes

remaining tasks

helmo’s picture

helmo commented

I've opened:
#2013971: Merging into Hosting site Backup Manager
#2013973: Merging into Hosting site Backup Manager

Steven, could you update both project pages?

omega8cc’s picture

omega8cc commented

Yep, I forgot to mention this - we are using it as a two separate projects in BOA, but at some point we have shortened the name only during testing for namespaces conflicts and I forgot commit/sync changes from https://github.com/omega8cc/provision_site_backup

steven jones’s picture

steven jones commented

I've updated the two project pages.

helmo’s picture

helmo commented

@omega8cc: Was the name length such a big problem? This feels like a recipe for much confusion. Lets try to keep the names consistent.

I wouldn’t mind changing that, but please lets discuss that in another issue.

omega8cc’s picture

omega8cc commented

@helmo - it was just a part of attempts to fix namespace conflicts, upgrades etc. Most of these tests ended up being reverted, and the real issues fixed later. We will revert to use the full project name in BOA to avoid confusion.

omega8cc’s picture

omega8cc commented
Issue summary: View changes

remaining task update

helmo’s picture

helmo commented
Status: Needs work » Needs review

The only remaining task is: Move hosting_backup_queue.drush.inc to the provision_site_backup_manager.
But as this runs in the @hostmaster context we could just leave it there.

Anyway a 6.x-2.0-alpha2 release is underway.

helmo’s picture

helmo commented
Issue summary: View changes

updated tasks

helmo’s picture

helmo commented
Issue summary: View changes
Status: Needs review » Fixed

Calling this fixed as I still agree with myself in #13.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.