Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Sep 2012 at 21:35 UTC
Updated:
1 Jan 2013 at 19:41 UTC
Description
This module shows form field help text as poshy tip (Poshy Tip Jquery Plugin)
It comes with seven different ready to use CSS styled tooltips. Various settings including tooltip style along with various other parameters can be configured at /admin/config/user-interface/nice-help/
Note: Nice help does not support tags within field help text. Help text would not be rendered as tooltip (but rather normally) if it contains any sort of markup.
Project link: http://drupal.org/sandbox/umarzaffer/1778316
Git: git clone http://git.drupal.org/sandbox/umarzaffer/1778316.git nice_help
Drupal: 7
Reviews of other projects:
Keyword Highlighter: http://drupal.org/node/1773526#comment-6451562
Block Local Tasks: http://drupal.org/node/1778396#comment-6451738
Lights Out: http://drupal.org/node/1740306#comment-6455034
Comments
Comment #1
2phaautomated review reported some problems
http://ventral.org/pareview/httpgitdrupalorgsandboxumarzaffer1778316git
your git clone link should be for anonymous users, eg. git clone http://git.drupal.org/sandbox/umarzaffer/1778316.git nice_help
Manual review:
indentation in the nice_help_help function needs some work I think, at least to keep it consistent.
You need to implement a hook_uninstall to remove the variables you are setting with variable_set
After enabling the module and going to the nice help admin page I get this error:
Notice: Undefined index: #description in nice_help_form_element() (line 274 of C:\xxx\xxx\d7\sites\all\modules\nice_help\nice_help.module).Comment #1.0
2phaCorrected git link for anonymous access
Comment #2
umarzaffer commentedThanks for the review,
I have taken care of all the things you have mentioned.
Update: Removed external Poshy Tip jquery plugin from module. Enforced requirement within .install file to have the jquery plugin downloaded and extracted to sites/sitename/libraries. Updated README.txt accordingly to help users with installation process. Corrected issues reported by Pareview.
Comment #2.0
umarzaffer commentedAdded reviews.
Comment #3
umarzaffer commentedApplying for review bonus as outlined here http://drupal.org/node/1410826.
Comment #4
klausiThere is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
I think your module should be called poshy, poshytip, fieldposhy or similar. nice_help is just too generic.
And this seems to be a duplicate: there is http://drupal.org/project/poshy_tip . Module duplication and fragmentation is a huge problem on drupal.org. We prefer collaboration over competition, so please open an issue in the poshy_tip issue queue to discuss this and what you would have to add. You should also get in contact with the maintainer(s) to work together on poshy_tip.
If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #5
umarzaffer commentedThanks klausi for the review,
Removed master branch and have set default branch to 7.x-1.0.
I have checked out poshy_tip module. This module gives the option to apply poshy tips on any CSS class which is configurable. Nice help is however targeted on form field help text, since there is no core theming support on form field help text in D7. Also, I have made all the poshy tip configuration available from the admin end.
Comment #6
klausiStill, this could be easily added to poshy_tip and to keep poshy stuff in one place. Please get in contact with the maintainer to discuss this as I said above and then report back here.
Comment #7
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #7.0
klausiAdded review.