This module will help you highlight any keywords in your site. For example you have content driven website where you want to display few words ex(the name of your company, location, or any other) in a different color that the normal site color. Then this module will help you achieve that.

You can add as many keywords as you want and can define a color-code for them ex- #FF00CC

Install this module and you can manage the keywords at Configuration->Content Authoring->Keyword Highlighter

This module is developed using Drupal 7

Project Link: http://drupal.org/sandbox/dharam1987/1765152
Git Link:http://git.drupal.org/sandbox/dharam1987/1765152.git
Git: git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/dharam1987/1765152.git keyword_highlighter
Drupal Code Sniffer :- http://ventral.org/pareview/httpgitdrupalorgsandboxdharam19871765152git

IMPORTANT INSTRUCTIONS TO FOLLOW FOR ENABLING IT
===========================================

You need to do the following setting in order for this module to work.
Follow the steps below after installing the Keyword Highlighter module.

1-> Go to Configuration->Content Authoring->Text Formats Direct Link - admin/config/content/formats

2-> We need to configure every available text format there by default you will have Filtered HTML, Full HTML, Plain text

3-> Click on "configure" link for each format

4-> Under "Enabled filters" section, enable(check) Keyword highlighter filter

5-> Below in this same configuration page, go to Filter processing order Make sure that "Keyword highlighter filter" is always below "Limit allowed HTML tags" To make it easy, you may set "Keyword highlighter filter" in the last position.

This is it, you can now add keywords and relavent colors.

#####################################################
Reviews of other modules
#####################################################

FIRST REVIEW
--------------------------
Required by role: http://drupal.org/node/1759252#comment-6419890
Password Field: http://drupal.org/node/1773016#comment-6432938
Taxonomy Views Switcher: http://drupal.org/node/1117208#comment-6441794

SECOND REVIEW
--------------------------------
Search Menu = http://drupal.org/node/1774662#comment-6447980
Jmol = http://drupal.org/node/1776652#comment-6447998
Prolike = http://drupal.org/node/1775004#comment-6448042

THIRD REVIEW
---------------------------------
FB_LIVE = http://drupal.org/node/1462634#comment-6556806
CSS Crush = http://drupal.org/node/1740956#comment-6557042
Node Overlay = http://drupal.org/node/1771086#comment-6557066

FORTH REVIEW
-----------------------------------
Hangman = http://drupal.org/node/1777990#comment-6592916
Search Custom = http://drupal.org/node/1597944#comment-6592998
Closed Question Scoreboard = http://drupal.org/node/1810360#comment-6593042

FIFTH REVIEW for RTBC
----------------------------------
Context Node Template = http://drupal.org/node/1728086#comment-6593064
Tinypass = http://drupal.org/node/1799148#comment-6593290
Node Reference Custom Text = http://drupal.org/node/1809404#comment-6593558

Comments

mayank-kamothi’s picture

Hi,dharam1987

Manual Review:

I have checked your module code and i found some space related issue like
[1] Use an indent of 2 spaces, with no tabs
[2] curly braces { should end a line, not start one
[3] missing space after comma
[4] Control statements should have one space between the control keyword and opening parenthesis
[5] the final ?> should be omitted from all code files
[6] @file block missing in inc file
[6] README.txt file is missing

Mayank kamothi

suhani.jain’s picture

Status: Needs review » Needs work

Hi dharam,

1)Please add git link corresponding to non-maintainer like 'http://git.drupal.org/sandbox/dharam1987/1765152.git' in a issue summary.

2)Please review your module using Coder Module and see the automated review here

3)In keyword_highlighter.module file, you have used variable 'kh_data_details' which you need to delete when the module is uninstalled i.e. in .install file.

4)You are getting the value of variables like 'kh_data_details' on line 52,but you havn't set this variable anywhere in your .module file
variable_get('kh_data_details','');

5)Custom function name should start with module name.

suhani.jain’s picture

Issue summary: View changes

added links

dharam1987’s picture

Hello Suhani and Mayank

Thank you for your reviews, I have used the code review module and has taken care of the errors.

@Suhani

#3- I have taken care of this

#4- I don't need to set this up for the first time use, if you see I am passing a 2nd parameter there which will give me a default empty value when it is not set.

#5 In my admin.inc file I have used kh(as the shortcut of my module name), and this is also an inclusion file, using my complete module name may make the function names lengthy, just wanted to know, is it absolute mandatory to do that ?

Thanks
Waiting for another review from you guys. !

dharam1987’s picture

Status: Needs work » Needs review

changing the status to needs review

dharam1987’s picture

Issue summary: View changes

added link to my git as suggested.

dharam1987’s picture

Issue summary: View changes

adding 3rd project review link

dharam1987’s picture

Issue tags: +PAreview: review bonus

Reviewed 3 projects

Required by role: http://drupal.org/node/1759252#comment-6419890
Password Field: http://drupal.org/node/1773016#comment-6432938
Taxonomy Views Switcher: http://drupal.org/node/1117208#comment-6441794

Applying for PAReview: review bonus

klausi’s picture

Title: Keyword Highlighter - Needs to be Reviewed » Keyword Highlighter
Status: Needs review » Needs work
Issue tags: -PAreview: review bonus

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

manual review:

  1. remove the 1765152 folder from your repository
  2. This module should be implemented as input filter, so that it is useful to anything that uses a text format. See hook_filter_info(). Currently it is totally hardcoded to the node body field and comments, it cannot be used on any other textfield or any other entity. You could copy from other filter modules like http://drupal.org/project/codefilter
  3. keyword_highlighter_add_keywords_submit(): do not use the raw POST values from $form_state['input'], use $form_state['values'] instead.

So I think this needs some work, because this would be 1000 times more useful as input filter. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

dharam1987’s picture

@klausi, thank you for taking the time to do the review, I am a bit confused in the 2nd point, seeking a bit of more explanation on that.

Now what I am doing is, before any node content is sent to the browser, I am finding the keyword and replacing them with Keyword.

According to your suggestion, what I need to do is, at the time of entering the data, i.e before saving any data to database, I should take that keyword and replace it and save to db?

And when user is trying to edit that content, I need to remove the my span code and convert it to the word so that user can edit it smoothly.

Kindly help me understanding that point. I think I got it wrong.

Thanks

dharam1987’s picture

@klausi :- I understood what you have said now, after reviewing various examples and understanding the hook_filter_info, its a great advice. I will use that. However I have found following issues with that which I am thinking to automate.

1- I need to instruct user to enable keyword filter after installing my module. (Not sure, but searching if there is any option to prompt user to enable that during my module installation)

2- I am replacing the colors using SPAN tag, however for Filtered HTML format, SPAN tag is not allowed, So in this case my span is getting filtered. I am trying to find how to surpass that part.

I am sure it would be there somewhere, anyhelp from anybody is greatly appreciated.

Thanks

dharam1987’s picture

Issue summary: View changes

added default branch to 7.x-1.x

dharam1987’s picture

Status: Needs work » Needs review
Issue tags: +PAreview: review bonus

Hello,

I have followed your instructions and have removed master branch, used hook_filter_info(), you may have a look at it again and provide your feedback.

here are the links to 3 projects which I had reviewed.

Search Menu http://drupal.org/node/1774662#comment-6447980
Jmol http://drupal.org/node/1776652#comment-6447998
Prolike http://drupal.org/node/1775004#comment-6448042

Applying for PAReview: review bonus

Thanks

umarzaffer’s picture

Category: task » bug
Priority: Normal » Critical

Hi dharam,

Following are the issues you might need to address that I have found:

Test environment I used
OS: Ubuntu 12.04
Browser: Chromium 18.0.1025.168 & Firefox 15.0

I have followed all the necessary configuration steps.

Functionality review

-----------------------------
On admin/config/content/keywords page
1. It is not clearly evident what value is expected to be used with color field.
2. Add help text for the fields.
3. Clicking on "Add one more" and then without entering any value with the fields
trying to "Remove one" does not work.
4. After successfully saving couple of keyword enteries, user is not able to delete
any keyword at random but rather always the last item is deletd. This limits the
use case for the admin to delete keywords higher in the list.
5. After successfully deleting a keyword entry and then immediately clicking
"Add one more" shows both fields pre-filled with the last keyword that was
deleted.
6. After saving keyword entries show status message to confirm if the saving
was successful or not.
7. I tried using both hex code like (#FF00CC) but that doesn't seem to work.
8. Also on the admin config page, there is an overlap of the text fields.

Code Review

-------------------
keyword_highlighter.module
1. Lines # 25 & 26. Enclose text within t() function.

klausi’s picture

Status: Needs review » Needs work

Restoring priority and category.

dharam1987’s picture

@umarzaffer

Thank you for your review, I am working on them to make the usability better, however about #7, I am a bit worried :) as that is the core of this module, it is working fine for me and I have checked with few instances as well.

Keyword - could be any of the word displayed in your node (case sensitive for now), in next commit, I am going to make it case insensitive.

Color - Hexadecimal colors.

Could you please check again and let me know if this works.

Thanks a ton for your wonderful review.

umarzaffer’s picture

Category: bug » task
Priority: Critical » Normal

I don't know what I was missing that time. Works just fine now.

dharam1987’s picture

Hello,

I have provided the option for user to select the keywords which they want to delete, they can check the fields and upon clicking save it will delete the selected ones. Added code so that keyword will work as case-insensitive.

Please review the code and let me know if it is all set.

here are the links to 3 projects which I had reviewed.

Search Menu http://drupal.org/node/1774662#comment-6447980
Jmol http://drupal.org/node/1776652#comment-6447998
Prolike http://drupal.org/node/1775004#comment-6448042

hkirsman’s picture

Could you change git address to non-mainter like said in comment #2. I copied your git command and it asked for password. Annoying :)
This is better: git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/dharam1987/1765152.git keyword_highlighter

Also:
Typo in module keyword_highlighter.info "Use full when you want" -> "Useful when you want".

You said in #8 "1- I need to instruct user to enable keyword filter after installing my module. (Not sure, but searching if there is any option to prompt user to enable that during my module installation)"

I solved that in my module Perfecto by using drupal_set_message(); and setting the latter parameter to 'warning' until certain requirements are met. But my module is still in the waitinglist and don't know what other people think about this kind of a feature.

hkirsman’s picture

Issue summary: View changes

added instructions for enabling it

dharam1987’s picture

@hkirsman : Thank you for pointing the issues out, I have fixed the typo and changed the git command.

Thanks

Waiting for admin review to plan my next course of action.

dharam1987’s picture

Status: Needs work » Needs review

changed status.. please review :)

dharam1987’s picture

review bonus, as I had reviewed 3 project as stated in my above comments. not sure why PAreview tag is not getting applied for my earlier comments, so trying again.

klausi’s picture

Status: Needs review » Needs work
Issue tags: -PAreview: review bonus +PAreview: security

Please add all your reviews to the issue summary. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

  1. "'#markup' => '<div>Add the keywords and there relevant color here.</div>',": all user facing text must run through t() for translation. Same for "'#description' => 'Enter a keyword. Ex- Drupal'," and possibly others.
  2. "$data = json_decode($data_json);": why is the system variable stored json encoded? The system will serialize PHP data structures for you anyway?
  3. "preg_match_all('/' . $keyword_array[$i]->keyword . '/i', $content, $kh_matches);": you should use preg_quote() here. Same in "preg_replace('/' . $amatch . '/', $replace_html, $content);"
  4. keyword_highlighter_replace_keywords() doc block: @param1 and @param2 are invalid doxygen tags, use @param. See http://drupal.org/node/1354#functions
  5. keyword_highlighter_generate_html(): this is vulnerable to XSS exploits as $keyword->color is user provided input that is printed unsanitized. Please read http://drupal.org/node/28984 again. If I enter #FF00DD";><script>alert('XSS');</script> as color there is a nasty javascript popup demonstrating the exploit.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

mayank-kamothi’s picture

Hi,dharam1987

I have check your module it works fine but i have one suggestion for that once i have click on Add one more than one row is added,but if i have checked and delete that selected row than it gives me "Keyword field is required.Color field is required." so it means that once i have add new row than i have to add keywords ???
i think if i checked blank row and i want to delete it than module will allow me to delete.

Thanks,
Mayank kamothi

dharam1987’s picture

Thank you for your comments, I got pre-occupied these days, I will start working on the fixes asap and will post it here.

dharam1987’s picture

Status: Needs work » Needs review

Hello Klausi,

I have fixed all the issues posted in #19 and it is ready for review. Tested my code in code sniffer again.

http://ventral.org/pareview/httpgitdrupalorgsandboxdharam19871765152git

Will review few projects to get the review bonus tag.

Thanks

dharam1987’s picture

Hello,

I have fixed the issues you have pointed in my project and I think it is ready for review again, please let me know if anything is missing. In the meanwhile I had reviewed 3 more new projects.

FB_LIVE = http://drupal.org/node/1462634#comment-6556806
CSS Crush = http://drupal.org/node/1740956#comment-6557042
Node Overlay = http://drupal.org/node/1771086#comment-6557066

Applying for reviewbonus

Thanks

klausi’s picture

Issue tags: +PAreview: security

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Please add all your reviews to the issue summary.

dharam1987’s picture

Hello Klausi,

Thank you for pointing that out, my apology as I was unaware of it and thought the project would not be reviewed unless I remove the security tag.

I will add all my reviews to my issue summery.

Thanks

dharam1987’s picture

Issue summary: View changes

added non-maintainer git access

cubeinspire’s picture

Category: task » bug
Status: Needs review » Needs work

Hi nice module! but ... :-)

There is a serious problem with the config form that saves the keywords and color codes as pointed out at http://drupal.org/node/1773526#comment-6451562

This is not a usability improvement but a real bug as you can find your self in some situations where is not possible to remove a keyword highlight...

How to arrive to this situation:
1. Create a keyword highlight using the form admin/config/content/keywords
Just enter a keyword and a well formated hexa color as #FF0055
(Check that everythings works - ok)

2. Go back to the form admin/config/content/keywords and edit the last entered keyword highlight and introduce a bad formated color code as "qsdjklhkl". Save the form.

->> There is no error message indicating a bad formated input !
->> Going back to the page to check, the last entered color is still visible (#FF0055)

3. Go back again to the form and delete the last entered malformed color code.
->> The entry is erased from the form
->> /!\ Going back to the site the first correct color code is still visible (#FF0055)
->> /!\ There is no way to delete it !!!!

cubeinspire’s picture

I've found this, maybe it can be of some use here.
See the Validating Forms part

http://drupal.org/node/751826

dharam1987’s picture

Hello logicdesign,

#1 - There is a serious problem with the config form that saves the keywords and color codes as pointed out at http://drupal.org/node/1773526#comment-6451562

Please be more specific on the points you want to mention here, as I believe I had fixed the required issues there, let me know the exact point which is not working for you. For deleting users are provided with the option to select the entries which they want to delete and can click on (Save and delete the selected ones) button.

#2- I can't duplicate the issue which you have pointed about deleting the keyword, as I find once it is deleted it is not being use anywhere, I am not sure if any sort of caching is happening at your end, please give me more clear steps to duplicate it.

#3- I will write custom validation to verify any code entered is a hexadecimal color code.

klausi’s picture

Category: bug » task

Project applications are tasks, switching category.

cubeinspire’s picture

Well the steps to follow to produce the bug are :

How to arrive to this situation:
1. Create a keyword highlight using the form admin/config/content/keywords
Just enter a keyword and a well formated hexa color as #FF0055
(Check that everythings works - ok)

2. Go back to the form admin/config/content/keywords and edit the last entered keyword highlight and introduce a bad formated color code as "qsdjklhkl". Save the form.

->> There is no error message indicating a bad formated input !
->> Going back to the page to check, the last entered color is still visible (#FF0055)

3. Go back again to the form and delete the last entered malformed color code.
->> The entry is erased from the form
->> /!\ Going back to the site the first correct color code is still visible (#FF0055)
->> /!\ There is no way to delete it !!!!

Yes it's a cache problem, maybe you should clear caches on form submit with cache_clear_all() or a more specific function.
See http://api.drupal.org/api/drupal/includes!cache.inc/function/cache_clear...

I also think there should be a validation process of the user entered values and an error message if there she/he enterd a malformed value before releasing the module.
In any case the form should not save data that is not an hexa string or that is an hexa string but is not starting with # and have more or less than 7 characters.

Maybe you have already think about that but another idea is to have a db table to store all the keywords and color codes, that could keep data more organized inside the db.

I really love your module, but without this scary problem of malformed/not-erased-values I would never install it on a production site.
Imagine if the webmaster makes a mistake on the configuration form, save it and then he cannot modify the colors again... the client will not be happy ;-)

In any case good job, keep it up !

cubeinspire’s picture

Security problem also.

If you enter:
#FF00FF;">Hey</span><img onload="alert('hello');" src="/d7/themes/bartik/logo.png"/><span color="#FF00FF

instead of #FF0055 all the html and javascript is outputted to the public website !!
An extra reason to parse the data, on form submission and on the website output.

dharam1987’s picture

On #31, check_plain is used to filter the data before displaying, that security problem is taken care off, however I strongly agree to your point of validating the hexadecimal color and I gonna write that validation.

So according to you, after you deleting the cache would solve the problem which you had mentioned, that is not occurring at my end, might be because my cache system is not caching it.

I gonna do it and get back to you.

Thanks

dharam1987’s picture

Any more reviews ? Have the bonus review tag aswell :)

Thanks

dharam1987’s picture

Status: Needs review » Needs work

I wonder, how my last comment is not posted, I might have done some mistake, here it is again.

I have fixed the issues mentioned in #30 and uploaded. Kindly review the project once and let me know if any thing more is required.

hexadecimal validation is added using regx, feel free to suggest me if there is any other better regx or method.

now data is being filtered using check_plain before saving into the db

maxlength allowed for color (textbox) is 7

Thanks

dharam1987’s picture

Status: Needs work » Needs review

forgot to change the status, changing the status to need review.

klausi’s picture

Issue tags: -PAreview: review bonus

manual review:

  1. keyword_highlighter_add_keywords_submit(): "When handling data, the golden rule is to store exactly what the user typed. When a user edits a post they created earlier, the form should contain the same things as it did when they first submitted it. This means that conversions are performed when content is output, not when saved to the database." make sure to read http://drupal.org/node/28984 again.
  2. keyword_highlighter_add_keywords_validate(): do not use the raw POST values from $form_state['input'], use $form_state['values'] instead.
  3. keyword_highlighter_add_keywords(): do not create link markup yourself, use l() instead.
  4. _keyword_highlighter_process(): the name "$data_json" does not make sense?
  5. keyword_highlighter_menu(): the path "admin/config/content/keywords" is unprotected and can be edited by any user?!

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

dharam1987’s picture

Status: Needs work » Needs review
Issue tags: +PAreview: review bonus

Hello,

I have addressed all the issues listed in #36

1- keyword_highlighter_add_keywords_submit(), deleted the code which was filtering the data, now the data is only filtered before outputting to user.

2- keyword_highlighter_add_keywords_validate used $form['values'] as instructed.

3- keyword_highlighter_add_keywords used l() to create the link.

4- _keyword_highlighter_process() changed the variable to kh_data_array (as the config data is stored in array format)

5- keyword_highlighter_menu(), added user_callback and permission, now only admin can access this, permission can be changed by admin aswell.

Reviewed the following 3 projects and added review bonus tag again.

Hangman = http://drupal.org/node/1777990#comment-6592916

Search Custom = http://drupal.org/node/1597944#comment-6592998

Closed Question Scoreboard = http://drupal.org/node/1810360#comment-6593042

Thanks

dharam1987’s picture

Issue summary: View changes

added all reviews

dharam1987’s picture

Issue summary: View changes

added 4th reviewed project links

frankye’s picture

Status: Needs work » Needs review

Hello dharam 1987,
I did review the code:

  1. "keyword_highlighter_add_keywords" - A good way of function name form is <module_name> _ <description> _form (for example: keyword_highlighter_add_keywords_form) - but then you need to change also the functions _submit, _callback and _validate. You can see in Drupal7 book
  2. "keyword_highlighter_add_keywords ($ form, & $ form_state, $ no_js_use = FALSE)" - What is the argument "$ no_js_use"? I think it is unnecessary
  3. "keyword_highlighter_generate_html ()" - and by comment # 36 "conversions are performed when content is output" variable "$ ori_keyword" should also be converted by. check_plain ()
  4. Add to info file link to your configuration - then you can view this on the list of modules page (this is a very helpful new feature in D7):
    configure = admin/config/content/keywords
    You can see more information here: http://drupal.org/node/542202
dharam1987’s picture

Status: Needs review » Needs work

changing status to needs work my self, franky has all valid points, I am fixing them now.

dharam1987’s picture

Hello Frankye,

I have fixed all the issues which you had pointed in #38, kindly review it once in your free time.

The PRReview Bonus tag was already added, expecting more deeper review again.

Thanks

klausi’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

Ok, went through the code and it looks good now. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

dharam1987’s picture

Thanks, do I need to add a review bonus tag again in order to get the project approved, or it is all set from your end now unless any other reviewers provide any feedback ?

Wondering the procedure to get the project approved as you said the code looks good now.

Thanks again

cubeinspire’s picture

I thnk RTBC got automatically aproved after 8 weeks (to be confirmed).
If you want to speed up the process you can apply for a review bonus and help on this :-)

dharam1987’s picture

Issue tags: +PAreview: review bonus

Another 3 reviews for faster RTBC
---------------------------------

Context Node Template = http://drupal.org/node/1728086#comment-6593064

Tinypass = http://drupal.org/node/1799148#comment-6593290

Node Reference Custom Text = http://drupal.org/node/1809404#comment-6593558

Thanks

dharam1987’s picture

Issue summary: View changes

moved the other review modules to last, added link to code sniffer auto review

cubeinspire’s picture

Hi again,

I don't want to block this project application but I notice that on line 145 of the admin.inc you are parsing also the submit button, that raise a warning each time the submit button is pressed:
Warning: Illegal string offset 'color' in keyword_highlighter_add_keywords_form_validate() (line 146 of /var/www/d7/sites/all/modules/keyword_highlighter/keyword_highlighter.admin.inc).

A simple additional test: is_array($kr) will solve that issue.
Line 145 should be: if (is_array($kr) && !_keyword_highlighter_validate_hexacolor($kr['color']) && $key != 'add_name') {

The rest looks good to me.

dharam1987’s picture

Hello logicdesign,

Thank you for your suggestion, but I think

if (!_keyword_highlighter_validate_hexacolor($kr['color']) && $key != 'add_name') {

This piece of code is already taking care of it, for the submit button the $key value is 'add_name' and I am checking that condition in the if statement, $key != 'add_name')

However I think this condition should be on top of the if condition... Let me put this out.

Thanks

dharam1987’s picture

Hi logicdesign,

I have tried a lot to duplicate the error from my end, but couldn't get it. However I have added code for safty shake, I think the warning was generating when $kr['color'] is being passed to _keyword_highlighter_validate_hexacolor so I have added the condition on the top.

Here is the new code.

if (is_array($kr)) {
      if (!_keyword_highlighter_validate_hexacolor($kr['color']) && $key != 'add_name') {
        form_set_error('color', t('Please provide a valid hexadecimal color. Ex - #00FF00'));
      }
    }
cubeinspire’s picture

Have you tried to 'Administer' > 'Site configuration' > 'Error reporting' ? There is a way to enable/disable the reporting.
This looks ready to have a full project access.

klausi’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for cross-checking this application logicdesign!

Thanks for your contribution, dharam1987!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

dharam1987’s picture

Thanks a lot klausi, finally huh !! I will still try to contribute more to drupal by reviewing such applications.

Thanks everybody

dharam1987’s picture

Hello,

http://drupal.org/project/keyword_highlighter is the project url of my full project, I am wondering why no download file option is there ? Is there anything else I need to do.

Thanks

klausi’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

added more project reviews for the 5th time to speed up RTBC process.