Add ARIA landmarks for Bartik theme

Lots of good ideas @design_dolphin - Thanks!

1) This needs to be tested, but think we got it into Core here #1183042: Regression: Add WAI-ARIA roles to Core blocks

I've been trying to keep issues organized under the tag aria

2) I like the idea of role="form" but think that might go better with the Forms API. It should be applied to all forms, right? In which case we need to set up a new issue.

Absolutely good to to look at, work on and share with others. @Jeff's AdaptiveTheme is a great starting point as is @John's Zen. Not sure which is using ARIA the best right now. Also modules like:
http://drupal.org/project/accessible
https://drupal.org/project/block_aria_landmark_roles

Good links for sure. Education is important & authoritative references certainly help.

Meta Issues are useful but can also bog down the process. Where we can it's good to reduce the load on the core maintainers. That being said, we want approval from folks focusing on Bartik & Seven. I'm not too worried about Stark, but we will be getting a new Core theme too i think (and that will need some review I think).

I like inventories. I also think I need a bit more explanation about what you've included in the navigational text above.

I'm totally happy to hear that you can put in some sustained time into this. Lots of work to do for sure. Main thing is to keep working on it as it can take a while to get things into Core.

I'm all for removing redundancy, but it's going to take some testing & screen shots to see how it works. I also think they were looking at ID's & not classes. Would have to talk to more CSS folks to see what type of a change that might make.

There's a Skype group where we have regular chats. They are also announced on http://groups.drupal.org/accessibility

bartik-aria-landmark-roles.patch queued for re-testing.

Just like Seven I think.

This is a simple addition of ARIA. There are no visual changes.

@no_longer_active_13 (previously @design_dolphin) added some suggestions but then left the community.

I think there are more places to add ARIA landmarks roles for this theme, but this is a basic implementation that's good to go.

Will do.. Thanks for enforcing good process..

Good enhancement. I've attached a screenshot and am marking this RTBC. Thanks everyone.

Hard to argue with a "W3C Editor's Draft 29 December 2012"!

But partly it comes back to your patch here:
+ <footer id="footer" role="contentinfo" class="clearfix">

We gotta get that issue fixed ASAP.

But yes, no concern with this. An important change.

We'll deal with the HTML5 issue elsewhere and just port this to that. I'll mark this RTBC now and we should be able to close this.

I just added a visualizations using juicy-studio's landmark mozilla accessibility plugin.

This might need to be a new issue, but noticed that the ARIA role contentinfo is used twice in the Bartik theme. It's easy enough to just nix one, but then I started to wonder why we have both <footer> & a <div id="footer">.

The W3C specifies "Within any document or application, the author SHOULD mark no more than one element with the contentinfo role." This is for information about the parent document like "copyrights and links to privacy statements".

So for the block of HTML below, which should have the contentinfo role?

 <div id="footer-wrapper"><footer class="section" role="contentinfo">

    <?php if ($page['footer_firstcolumn'] || $page['footer_secondcolumn'] || $page['footer_thirdcolumn'] || $page['footer_fourthcolumn']): ?>
      <div id="footer-columns" class="clearfix">
        <?php print render($page['footer_firstcolumn']); ?>
        <?php print render($page['footer_secondcolumn']); ?>
        <?php print render($page['footer_thirdcolumn']); ?>
        <?php print render($page['footer_fourthcolumn']); ?>
      </div> <!-- /#footer-columns -->
    <?php endif; ?>

    <?php if ($page['footer']): ?>
      <div id="footer" role="contentinfo" class="clearfix">
        <?php print render($page['footer']); ?>
      </div> <!-- /#footer -->
    <?php endif; ?>

  </footer></div> <!-- /.section, /#footer-wrapper -->

Thanks Sarah for highlighting this in your DrupalCon talk - http://sydney2013.drupal.org/creating-dynamic-and-accessible-content-dru... - very useful.

So for clarification, you'd suggest keeping <div id="footer" role="contentinfo" class="clearfix">

Ok, it's fixed up here.

#23: bartik-aria-landmark-contentinfo-23.patch queued for re-testing.