Patch (to be ported)
Project:
Simplenews
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Oct 2012 at 13:59 UTC
Updated:
1 May 2015 at 22:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
deggertsen commented+1 here. I was surprised to find that this was not available. I assume you could make a custom view to count all the rows of subscribers for each newsletter, but it would be much better to have this included on the page admin/config/services/simplenews.
Thanks
Comment #2
deggertsen commentedThis was simple enough I went ahead and did it. Please review and mark RTBC if it works for you.
Comment #3
sumeet.pareek commentedGood quick fix there @deggertsen. I have just tested the patch and it works perfectly fine. But I would still submit a new one only to set the whitespaces in order on 2 occassions in your patch. I am really sorry for acting like a 'best practices nazi', but I am right now in a sprint re-learning how to review patches :-)
Will read some more about reviewing and submitting patches and submit your code with whitespace issues fixed.
Comment #4
sumeet.pareek commentedHere is the patch re-rolled after correcting the whitespace styles.
Comment #5
Anonymous (not verified) commentedMy hunch is that a good deal of the Simplenews reporting that one wants can be accomplished using a combination of:
plus one of the following.
Their promise is being able to assemble the reporting infrastructure that is right for your site.
There may or may not be value in also using Simplenews Statistics, given the apparently immature state of its D7 version.
Bob
Comment #6
bjobra commentedWow, I just made my first patch, and it worked. I tried with views to get this statistics, but this patch made the job easy and right. Thanks a lot. Another step in my drupalizing. And i found 12300 members....
Comment #7
caktux commentedlooks good, please merge
Comment #8
berdirThis seems useful, I was recently wondering myself why that doesn't exist.
Committed, this should be ported to 7.x-2.x and 8.x-1.x as well.