Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.It would greatly help if there were more tests to cover different functionality.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | metatag-n1848338-17.patch | 6.51 KB | damienmckenna |
| #15 | metatag-n1848338-15.patch | 6.41 KB | damienmckenna |
Comments
Comment #1
makangus commentedDo you have a few functions or features in mind you want more tests for?
Comment #2
damienmckennaDoes that answer it? =)
As for a starting point - maybe start with testing additional meta tags?
Comment #3
damienmckennaComment #4
makangus commentedOk, when I have some time I'll write some stuff and see what you think.
Comment #5
makangus commentedSimpletest for metatag_opengraph. please let me know what you think. This should take care of #1857700: OpenGraph tags not validating correctly via Facebook's dev tools as well.
Comment #6
damienmckenna#5: metatag-opengraph-1848338.patch queued for re-testing.
Comment #8
damienmckennaThis includes a simple list of test scenarios that need to be added.
Comment #9
damienmckennaI've committed the patch from #8, now back to needing work to actually *write* the tests :)
Comment #10
damienmckennaSome further minor tweaking.
Comment #12
damienmckennaI think I typood one of the test case IDs.
Comment #13
larowlan@DamienMcKenna asked for tests in #1970362: Support all attributes of the meta element to be added here.
Comment #14
larowlangreeen
Comment #15
damienmckennaThanks for that larowlan! This adds some additional minor improvements.
Comment #17
damienmckennaOk, lets see if this works.
Comment #18
damienmckennaComment #19
damienmckennaCommited! Thanks larowlan!