Comments

makangus’s picture

Do you have a few functions or features in mind you want more tests for?

damienmckenna’s picture

StatusFileSize
new0 bytes

Test all the things

Does that answer it? =)

As for a starting point - maybe start with testing additional meta tags?

damienmckenna’s picture

StatusFileSize
new71.42 KB
makangus’s picture

Ok, when I have some time I'll write some stuff and see what you think.

makangus’s picture

Status: Active » Needs review
StatusFileSize
new1.38 KB

Simpletest for metatag_opengraph. please let me know what you think. This should take care of #1857700: OpenGraph tags not validating correctly via Facebook's dev tools as well.

damienmckenna’s picture

#5: metatag-opengraph-1848338.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, metatag-opengraph-1848338.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new3.81 KB

This includes a simple list of test scenarios that need to be added.

damienmckenna’s picture

Status: Needs review » Active

I've committed the patch from #8, now back to needing work to actually *write* the tests :)

damienmckenna’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.85 KB

Some further minor tweaking.

Status: Needs review » Needs work

The last submitted patch, 10: metatag-n1848338-10.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new2.85 KB

I think I typood one of the test case IDs.

larowlan’s picture

StatusFileSize
new2.9 KB
new5.64 KB

@DamienMcKenna asked for tests in #1970362: Support all attributes of the meta element to be added here.

larowlan’s picture

greeen

damienmckenna’s picture

StatusFileSize
new6.41 KB

Thanks for that larowlan! This adds some additional minor improvements.

Status: Needs review » Needs work

The last submitted patch, 15: metatag-n1848338-15.patch, failed testing.

damienmckenna’s picture

StatusFileSize
new6.51 KB

Ok, lets see if this works.

damienmckenna’s picture

Status: Needs work » Needs review
damienmckenna’s picture

Status: Needs review » Fixed

Commited! Thanks larowlan!

  • DamienMcKenna committed a8e9b1f on 7.x-1.x
    Issue #1848338 by larowlan, DamienMcKenna: Added more tests, especially...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.