Problem/Motivation

  • Currently, many Views method names use underscores rather than camelCase.

Proposed resolution

  • Later in the release cycle, rename classes according to the new standard.
  • Convert method names exactly from underscore_separated() to camelCase(). So,
    foo_the_bar()
    becomes
    fooTheBar().

i.e.:

From To
view_argument_validate_user() viewArgumentValidateUser()
test_plugin_argument_default_current_user() testPluginArgumentDefaultCurrentUser()
test_views_trim_text() testViewsTrimText()

The three above were in the previous version of the issue summary, cf. #4 and #5 below. These three are the only ones not in the list below, which is based on #13.

Before replacing any method names, we must check that the new name is not already in use. Also, #11 suggests that we consider changing to more descriptive names instead of mechanically replacing "camel_case" with "camelCase".

Instructions for creating issues

As part of the Portland Get Involved with Core Sprint new contributors will be creating issues.
Until all the issues are created, these instructions are here so they are in a central location.

  1. Use this link to create a sub-issue for each of the below.
  2. Edit this issue and add a link to the new sub-issue in the appropriate "Issue" column in this issue summary using the syntax [#nid].
From To Access Issue
add_additional_fields() addAdditionalFields() #2001318: Rename Views method add_additional_fields() to addAdditionalFields()
add_field() addField() #2002144: Rename Views method add_field() to addField() Assigned to: drupalway
add_groupby() addGroupby() public #2001320: Rename Views method add_groupby() to addGroupBy() Assigned to: chrisguindon
add_having() addHaving() #2002270: Remove views method add_having()
add_having_expression() addHavingExpression() public #2001330: Rename Views method add_having_expression() to addHavingExpression()
add_filter() addFilter() public #2020697: Rename Views method add_filter() to addFilter()
add_orderby() addOrderby() public #2002272: Rename Views method add_orderby() to addOrderby() Assigned to: elvis2
add_relationship() addRelationship() public #2002274: Rename Views method add_relationship() to addRelationship() Assigned to: elvis2
add_self_tokens() addSelfTokens() protected #2002276: Rename Views method add_self_tokens() to addSelfTokens() Assigned to: elvis2
add_signature() addSignature() public #2002280: Rename Views method add_signature() to addSignature() Assigned to: elvis2
add_table() addTable() #2002332: Rename Views method add_table() to addTable() Assigned to: mikedotexe
add_tag() addTag() public #2002338: Rename Views method add_tag() to addTag() Assigned to: elvis2
add_where() addWhere() public #2002340: Rename Views method add_where() to addWhere() Assigned to: elvis2
add_where_expression() addWhereExpression() public #2002344: Rename Views method add_where_expression() to addWhereExpression() Assigned to: elvis2
adjust_join() adjustJoin() #2002346: Rename Views method adjust_join() to adjustJoin() Assigned to: crowdcg
advanced_render() advancedRender() #2002348: Rename Views method advanced_render() to advancedRender()
aggregation_method_distinct() aggregationMethodDistinct() #2002350: Rename Views method aggregation_method_distinct() to aggregationMethodDistinct() Assigned to: Gang Wang
aggregation_method_simple() aggregationMethodSimple() #2002354: Rename Views method aggregation_method_simple() to aggregationMethodSimple() Assigned to: Gang Wang
allow_advanced_render() allowAdvancedRender() #2002356: Rename Views method allow_advanced_render() to allowAdvancedRender() Assigned to: Gang Wang
alter_display_options() alterDisplayOptions() #2002358: Rename Views method alter_display_options() to alterDisplayOptions() Assigned to: jazzdrive3
alter_subquery_condition() alterSubqueryCondition() #2002360: Rename Views method alter_subquery_condition() to alterSubqueryCondition() Assigned to: brandon_beeler
attach_to() attachTo() #2002362: Rename Views method attach_to() to attachTo() Assigned to: Gang Wang
block_display_options() blockDisplayOptions() #2002366: Rename Views method block_display_options() to blockDisplayOptions() Assigned to: Gang Wang
build_condition() buildCondition() #2002368: Rename Views method build_condition() to buildCondition() Assigned to: baldwinlouie
build_display_options() buildDisplayOptions() #2002370: Rename Views method build_display_options() to buildDisplayOptions()
build_filters() buildFilters() #2002372: Rename Views method build_filters() to buildFilters() Assigned to: baldwinlouie
build_form() buildForm() #2002374: Rename Views method build_form() to buildForm()
build_form_style() buildFormStyle() #2002376: Rename Views method build_form_style() to buildFormStyle() Assigned to: hugo.lallo
build_group_form() buildGroupForm() #2002378: Rename Views method build_group_form() to buildGroupForm()
build_group_options() buildGroupOptions() #2002380: Rename Views method build_group_options() to buildGroupOptions()
build_group_submit() buildGroupSubmit() #2002382: Rename Views method build_group_submit() to buildGroupSubmit()
build_group_validate() buildGroupValidate() #2002384: Rename Views method build_group_validate() to buildGroupValidate() Assigned to: nathangervais
build_sort() buildSort() #2002388: Rename Views method build_sort() to buildSort()
build_sort_post() buildSortPost() #2002390: Rename Views method build_sort_post() to buildSortPost() Assigned to: suhel.rangnekar
build_sorts() buildSorts() #2002394: Rename Views method build_sorts() to buildSorts() Assigned to: broeker
cache_expire() cacheExpire() #2002396: Rename Views method cache_expire() to cacheExpire() Assigned to: nathangervais
cache_flush() cacheFlush() #2002398: Rename Views method cache_flush() to cacheFlush() Assigned to: web.dev.cas
cache_get() cacheGet() #2002408: Rename Views method cache_get() to cacheGet() Assigned to: fmizzell
cache_set() cacheSet() #2002410: Rename Views method cache_set() to cacheSet() Assigned to: nathangervais
cache_set_expire() cacheSetExpire() #2002412: Rename Views method cache_set_expire() to cacheSetExpire() Assigned to: davmorr
cache_start() cacheStart() #2002414: Rename Views method cache_start() to cacheStart() Assigned to: theladebug
can_build_group() canBuildGroup() #2002416: Rename Views method can_build_group() to canBuildGroup()
can_group() canGroup() #2002418: Rename Views method can_group() to canGroup()
check_access() checkAccess() #2002420: Rename Views method check_access() to checkAccess() Assigned to: oenie
clear_fields() clearFields() #2002422: Rename Views method clear_fields() to clearFields()
click_sort() clickSort() #2002424: Rename Views method click_sort() to clickSort() Assigned to: web.dev.cas
click_sortable() clickSortable() #2002426: Rename Views method click_sortable() to clickSortable()
compile_fields() compileFields() #2002428: Rename Views method compile_fields() to compileFields()
condition_namespace() conditionNamespace() #2002430: Rename Views method condition_namespace() to conditionNamespace()
convert_exposed_input() convertExposedInput() #2002432: Rename Views method convert_exposed_input() to convertExposedInput() Assigned to: sillygwailo
create_view() createView() #2002434: Rename Views method create_view() to createView() Assigned to: sillygwailo
default_access_denied() defaultAccessDenied() #2002436: Rename Views method default_access_denied() to defaultAccessDenied() Assigned to: baldwinlouie
default_action() defaultAction() #2002438: Rename Views method default_action() to defaultAction() Assigned to: malcomio
default_actions() defaultActions() #2002442: Rename Views method default_actions() to defaultActions() Assigned to: baldwinlouie
default_argument_form() defaultArgumentForm() #2002444: Rename Views method default_argument_form() to defaultArgumentForm() Assigned to: fmizzell
default_default() defaultDefault() #2002446: Rename Views method default_default() to defaultDefault() Assigned to: fmizzell
default_display_filters() defaultDisplayFilters() #2003468: Rename Views method default_display_filters() to defaultDisplayFilters() Assigned to: Maxis
default_display_filters_user() defaultDisplayFiltersUser() #2002448: Rename Views method default_display_filters_user() to defaultDisplayFiltersUser()
default_display_options() defaultDisplayOptions() #2002450: Rename Views method default_display_options() to defaultDisplayOptions() Assigned to: jazzdrive3
default_display_sorts() defaultDisplaySorts() #2002452: Rename Views method default_display_sorts() to defaultDisplaySorts() Assigned to: hoZt
default_display_sorts_user() defaultDisplaySortsUser() #2002454: Rename Views method default_display_sorts_user() to defaultDisplaySortsUser() Assigned to: baldwinlouie
default_empty() defaultEmpty() #2002456: Rename Views method default_empty() to defaultEmpty() Assigned to: ericthelast
default_ignore() defaultIgnore() #2002458: Rename Views method default_ignore() to defaultIgnore() Assigned to: baldwinlouie
default_not_found() defaultNotFound() #2002460: Rename Views method default_not_found() to defaultNotFound()
default_summary() defaultSummary() #2002462: Rename Views method default_summary() to defaultSummary()
default_summary_form() defaultSummaryForm() #2002464: Rename Views method default_summary_form() to defaultSummaryForm() Assigned to: endorn
document_self_tokens() documentSelfTokens() #2002466: Rename Views method document_self_tokens() to documentSelfTokens()
element_classes() elementClasses() #2002468: Rename Views method element_classes() to elementClasses()
element_label_classes() elementLabelClasses() #2002472: Rename Views method element_label_classes() to elementLabelClasses() Assigned to: endorn
element_label_type() elementLabelType() #2002474: Rename Views method element_label_type() to elementLabelType() Assigned to: brennanmh
element_type() elementType() #2002476: Rename Views method element_type() to elementType()
element_wrapper_classes() elementWrapperClasses() #2002478: Rename Views method element_wrapper_classes() to elementWrapperClasses() Assigned to: arielqgold
element_wrapper_type() elementWrapperType() #2002480: Rename Views method element_wrapper_type() to elementWrapperType()
ensure_path() ensurePath() #2002482: Rename Views method ensure_path() to ensurePath()
ensure_table() ensureTable() #2002484: Rename Views method ensure_table() to ensureTable() Assigned to: drupee
even_empty() evenEmpty() #2002486: Rename Views method even_empty() to evenEmpty() Assigned to: crowdcg
exception_title() exceptionTitle() #2002488: Rename Views method exception_title() to exceptionTitle() Assigned to: baldwinlouie
execute_count_query() executeCountQuery() #2002490: Rename Views method execute_count_query() to executeCountQuery()
exposed_filter_applied() exposedFilterApplied() #2002494: Rename Views method exposed_filter_applied() to exposedFilterApplied()
exposed_form_alter() exposedFormAlter() #2002496: Rename Views method exposed_form_alter() to exposedFormAlter() Assigned to: baldwinlouie
exposed_form_submit() exposedFormSubmit() #2002498: Rename Views method exposed_form_submit() to exposedFormSubmit()
exposed_form_validate() exposedFormValidate() #2002500: Rename Views method exposed_form_validate() to exposedFormValidate() Assigned to: fmizzell
exposed_translate() exposedTranslate() #2002502: Rename Views method exposed_translate() to exposedTranslate() Assigned to: arh1
gather_headers() gatherHeaders() #2002504: Rename Views method gather_headers() to gatherHeaders() Assigned to: endorn
get_access_callback() getAccessCallback() Removed in #1800998: Use route system instead of hook_menu() in Views
get_aggregation_info() getAggregationInfo() #2002892: Rename Views method get_aggregation_info() to getAggregationInfo()
get_argument() getArgument() #2002894: Rename Views method get_argument() to getArgument() Assigned to: crowdcg
get_channel_elements() getChannelElements() #2002896: Rename Views method get_channel_elements() to getChannelElements() Assigned to: hoZt
get_current_page() getCurrentPage() #2002898: Rename Views method get_current_page() to getCurrentPage()
get_default_argument() getDefaultArgument() #2002900: Rename Views method get_default_argument() to getDefaultArgument() Assigned to: diarmy
get_description() getDescription() #2002902: Rename Views method get_description() to getDescription()
get_elements() getElements() #2002904: Rename Views method get_elements() to getElements()
get_entity() getEntity() #2002906: Rename Views method get_entity() to getEntity()
get_entity_tables() getEntityTables() #2002908: Rename Views method get_entity_tables() to getEntityTables() Assigned to: lokapujya
get_field() getField() #2002910: Rename Views method get_field() to getField() Assigned to: toddtomlinson
get_field_alias() getFieldAlias() #2002912: Rename Views method get_field_alias() to getFieldAlias() Assigned to: markie
get_field_value() getFieldValue() #2002914: Rename Views method get_field_value() to getFieldValue()
get_formula() getFormula() #2002916: Rename Views method get_formula() to getFormula() Assigned to: sillygwailo
get_items() getItems() #2002918: Rename Views method get_items() to getItems()
get_items_per_page() getItemsPerPage() #2002920: Rename Views method get_items_per_page() to getItemsPerPage() Assigned to: Maxis
get_join_data() getJoinData() #2002924: Rename Views method get_join_data() to getJoinData() Assigned to: markie
get_lifespan() getLifespan() #2002964: Rename Views method get_lifespan() to getLifespan() Assigned to: markie
get_non_aggregates() getNonAggregates() #2002966: Rename Views method get_non_aggregates() to getNonAggregates() Assigned to: kenianbei
get_offset() getOffset() #2002968: Rename Views method get_offset() to getOffset()
get_pager_id() getPagerId() #2002970: Rename Views method get_pager_id() to getPagerId()
get_pager_total() getPagerTotal() #2003452: Rename Views method get_pager_total() to getPagerTotal() Assigned to: baldwinlouie
get_plugin() getPlugin() #2003044: Rename Views method get_plugin() to getPlugin()
get_render_tokens() getRenderTokens() #2003268: Rename Views method get_render_tokens() to getRenderTokens()
get_row_class() getRowClass() #2003338: Rename Views method get_row_class() to getRowClass()
get_sort_name() getSortName() #2003378: Rename Views method get_sort_name() to getSortName()
get_table_info() getTableInfo() #2003472: Rename Views method get_table_info() to getTableInfo()
get_temporary_view() getTemporaryView() #2003476: Rename Views method get_temporary_view() to getTemporaryView() Assigned to: baldwinlouie
get_title() getTitle() #2002250: Rename Views method get_title() to getTitle()
get_token_values_recursive() getTokenValuesRecursive() #2003484: Rename Views method get_token_values_recursive() to getTokenValuesRecursive() Assigned to: sillygwailo
get_total_items() getTotalItems() #2003494: Rename Views method get_total_items() to getTotalItems()
get_value() getValue() #2003496: Rename Views method get_value() to getValue()
get_value_options() getValueOptions() #2003500: Rename Views method get_value_options() to getValueOptions()
get_where_args() getWhereArgs() #2003410: Rename Views method get_where_args to getWhereArgs()
group_form() groupForm() #2003506: Rename Views method group_form() to groupForm()
group_multiple_exposed_input() groupMultipleExposedInput() #2003508: Rename Views method group_multiple_exposed_input() to groupMultipleExposedInput()
has_default_argument() hasDefaultArgument() #2002866: Rename Views method has_default_argument() to hasDefaultArgument() Assigned to: mcpuddin
has_more_records() hasMoreRecords() #2002868: Rename Views method has_more_records() to hasMoreRecords() Assigned to: baldwinlouie
instantiate_view() instantiateView() #2002872: Rename Views method instantiate_view() to instantiateView() Assigned to: hansenm
is_exception() isException() #2002878: Rename Views method is_exception() to isException()
is_value_empty() isValueEmpty() #2002880: Rename Views method is_value_empty() to isValueEmpty() Assigned to: toddtomlinson
items_per_page_exposed() itemsPerPageExposed() #2002882: Rename Views method items_per_page_exposed() to itemsPerPageExposed() Assigned to: aspilicious
left_query() leftQuery() #2002884: Rename Views method left_query() to leftQuery() Assigned to: aspilicious
load_entities() loadEntities() #2002886: Rename Views method load_entities() to loadEntities() Assigned to: misselbeck
mark_table() markTable() #2003514: Rename Views method mark_table() to markTable()
offset_exposed() isOffsetExposed() #2003412: Rename Views method offset_exposed() to isOffsetExposed() Assigned to: lajical
op_between() opBetween() #2003428: Rename Views method op_between() to opBetween()
op_contains() opContains() #2003554: Rename Views method op_contains() to opContains()
op_empty() opEmpty() #2003556: Rename Views method op_empty() to opEmpty()
op_ends() opEndsWith() #2003558: Rename Views method op_ends() to opEndsWith()
op_equal() opEqual() #2003582: Rename Views method op_equal() to opEqual()
op_helper() opHelper() #2003550: Rename Views method op_helper() to opHelper() Assigned to: ThijsFeryn
op_longer() opLongerThan() #2003566: Rename Views method op_longer() to opLongerThan()
op_not() opNotLike() #2003548: Rename Views method op_not() to opNotLike() Assigned to: cam10025
op_not_ends() opNotEndsWith() protected #2003540: Rename Views method op_not_ends() to opNotEnds(), #2020377: Rename Views method opNotEnds() to opNotEndsWith().
op_not_starts() opNotStartsWith() protected #2003538: Rename Views method op_not_starts() to opNotStartsWith()
op_regex() opRegex() #2003536: Rename Views method op_regex() to opRegex()
op_shorter() opShorterThan() #2003532: Rename Views method op_shorter() to opShorterThan()
op_simple() opSimple() #2003522: Rename Views method op_simple() to opSimple()
op_starts() opStartsWith() #2003510: Rename Views method op_starts() to opStartsWith()
op_word() opContainsWord() #2003470: Rename Views method op_word() to opContainsWord() Assigned to: sillygwailo
operator_form() operatorForm() #2003438: Rename Views method operator_form to operatorForm() Assigned to: trevjs
operator_options() operatorOptions() public #2003464: Rename Views method operator_options() to operatorOptions() Assigned to: Dan Reinders
operator_submit() operatorSubmit() #2003462: Rename Views method operator_submit() to operatorSubmit() Assigned to: Dan Reinders
operator_validate() operatorValidate() #2003460: Rename Views method operator_validate() to operatorValidate() Assigned to: baldwinlouie
operator_values() operatorValues() #2003458: Rename Views method operator_values() to operatorValues() Assigned to: Dan Reinders
page_display_options() pageDisplayOptions() #2003436: Rename Views method page_display_options() to pageDisplayOptions() Assigned to: Dan Reinders
page_feed_display_options() pageFeedDisplayOptions() #2003386: Rename Views method page_feed_display_options() to pageFeedDisplayOptions() Assigned to: Dan Reinders
post_render() postRender() #2020693: Rename Views method post_render() to postRender()
pre_execute() preExecute() #2003368: Rename Views method pre_execute() to preExecute()
pre_render() preRender() #2003366: Rename Views method pre_render() to preRender()
prepare_filter_select_options() prepareFilterSelectOptions() #2003364: Rename Views method prepare_filter_select_options() to prepareFilterSelectOptions()
process_summary_arguments() processSummaryArguments() #2003356: Rename Views method process_summary_arguments() to processSummaryArguments() Assigned to: drupalway
queue_table() queueTable() #2003354: Rename Views method queue_table() to queueTable() Assigned to: kenianbei
reduce_value_options() reduceValueOptions() #2003352: Rename Views method() to reduceValueOptions() Assigned to: ericthelast
render_altered() renderAltered() #2003350: Rename Views method render_altered() to renderAltered()
render_as_link() renderAsLink() #2003348: Rename Views method render_as_link() to renderAsLink()
render_exposed_form() renderExposedForm() #2003346: Rename Views method render_exposed_form() to renderExposedForm() Assigned to: JimSmith
render_fields() renderFields() #2003344: Rename Views method render_fields() to renderFields() Assigned to: kenianbei
render_grouping() renderGrouping() #2003334: Rename Views method render_grouping() to renderGrouping()
render_grouping_sets() renderGroupingSets() #2003332: Rename Views method render_grouping_sets() to renderGroupingSets()
render_items() renderItems() #2003330: Rename Views method render_items() to renderItems() Assigned to: ericthelast
render_link() renderLink() #2056943: Convert render_link to renderLink
render_text() renderText() #2003328: Rename Views method render_text() to renderText()
render_textarea() renderTextarea() #2003324: Rename Views method render_textarea() to renderTextarea()
render_trim_text() renderTrimText() #2003322: Rename Views method render_trim_text() to renderTrimText() Assigned to: borisson_
reset_form() resetForm() #2003320: Rename Views method reset_form() to resetForm()
restore_headers() restoreHeaders() #2003318: Rename Views method restore_headers() to restoreHeaders()
retrieve_validated_view() retrieveValidatedView() protected #2003316: Rename Views method retrieve_validated_view() to retrieveValidatedView()
row_style_options() rowStyleOptions() protected #2003312: Rename Views method row_style_options() to rowStyleOptions()
sanitize_columns() sanitizeColumns() #2003310: Rename Views method sanitize_columns() to sanitizeColumns()
set_argument() setArgument() #2003308: Rename Views method set_argument() to setArgument()
set_breadcrumb() setBreadcrumb() #2003306: Rename Views method set_breadcrumb() to setBreadcrumb() Assigned to: markie
set_count_field() setCountField() #2003304: Rename Views method set_count_field() to setCountField()
set_current_page() setCurrentPage() #2003292: Rename Views method set_current_page() to setCurrentPage() Assigned to: ricky.middaugh
set_distinct() setDistinct() #2003288: Rename Views method set_distinct() to setDistinct()
set_group_operator() setGroupOperator() #2003300: Rename Views method set_group_operator() to setGroupOperator()
set_header() setHeader() #2003284: Remove Views method set_header()
set_items_per_page() setItemsPerPage() #2003282: Rename Views method set_items_per_page() to setItemsPerPage() Assigned to: drupee
set_limit() setLimit() #2003280: Rename Views method set_limit() to setLimit() Assigned to: kenianbei
set_offset() setOffset() #2003276: Rename Views method set_offset() to setOffset() Assigned to: markie
set_override_options() setOverrideOptions() #2003274: Rename Views method set_override_options() to setOverrideOptions() Assigned to: dbcollies
set_validated_view() setValidatedView() #2003272: Rename Views method set_validated_view() to setValidatedView() Assigned to: kenianbei
set_where_group() setWhereGroup() #2003270: Rename Views method set_where_group() to setWhereGroup() Assigned to: markie
show_build_group_button() showBuildGroupButton() #2003266: Rename Views method show_build_group_button() to showBuildGroupButton()
show_build_group_form() showBuildGroupForm() #2003264: Rename Views show_build_group_form() to showBuildGroupForm()
show_operator_form() showOperatorForm() #2003262: Rename Views show_operator_form() to showOperatorForm()
show_sort_form() showSortForm() #2003258: Rename Views show_sort_form() to showSortForm() Assigned to: markie
show_value_form() showValueForm() #2003252: Rename Views method show_value_form() to showValueForm()
sort_options() sortOptions() #2003246: Rename Views method sort_options() to sortOptions() Assigned to: nathangervais
sort_submit() sortSubmit() #2003244: Rename Views method sort_submit(() to sortSubmit() Assigned to: hoZt
sort_validate() sortValidate() #2003242: Rename Views method sort_validate() to sortValidate() Assigned to: farfanfelipe
store_group_input() storeGroupInput() #2003240: Rename Views method store_group_input() to storeGroupInput()
summary_argument() summaryArgument() #2003238: Rename Views summary_argument() to summaryArgument() Assigned to: nathangervais
summary_basics() summaryBasics() #2002988: Rename Views method summary_basics() to summaryBasics() Assigned to: kenianbei
summary_join() summaryJoin() #2020695: Rename Views method summary_join() to summaryJoin()
summary_name() summaryName() #2002986: Rename Views method summary_name() to summaryName()
summary_name_field() summaryNameField() #2002982: Rename Views method summary_name_field() to summaryNameField()
summary_query() summaryQuery() #2002980: Rename Views method summary_query() to summaryQuery() Assigned to: Gang Wang
summary_sort() summarySort() #2002978: Rename Views method summary_sort() to summarySort() Assigned to: crowdcg
title_query() titleQuery() #2002974: Rename Views method title_query() to titleQuery()
tokenize_value() tokenizeValue() #2002972: Rename Views method tokenize_value() to tokenizeValue() Assigned to: lokapujya
update_page_info() updatePageInfo() #2002952: Rename Views method update_page_info() to updatePageInfo()
use_count_query() useCountQuery() #2002950: Rename Views method use_count_query() to useCountQuery()
use_pager() usePager() #2002948: Rename Views method use_pager() to usePager() Assigned to: toddtomlinson
use_string_group_by() useStringGroupBy() #2002946: Rename Views method lgtm() to useStringGroupBy() Assigned to: malcomio
uses_breadcrumb() usesBreadcrumb() #2002944: Rename Views method uses_breadcrumb() to usesBreadcrumb()
uses_exposed() usesExposed() #2002942: Rename Views method uses_exposed() to usesExposed() Assigned to: jastraat
uses_tokens() usesTokens() #2002938: Rename Views method uses_tokens() to usesTokens() Assigned to: nathangervais
validate_argument() validateArgument() #2002934: Rename Views method validate_argument() to validateArgument()
value_form() valueForm() #2002932: Rename Views method value_form() to valueForm()
value_submit() valueSubmit() #2003236: Rename Views method value_submit() to valueSubmit() Assigned to: kenianbei
value_validate() valueValidate() #2002930: Rename Views method value_validate() to valueValidate() Assigned to: markie
wizard_form() wizardForm() public #2002928: Rename Views method wizard_form() to wizardForm()
wizard_submit() wizardSubmit() public #2001672: Rename Views method wizard_submit() to wizardSubmit()

Follow ups

#2020615: [META] Introduce PHP interfaces for views plugins

Files: 
CommentFileSizeAuthor
#13 views_methods.txt9.39 KBbenjifisher

Comments

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

I notice this is a meta issue. Are you expecting patches here, or are you going to split things up somehow first?

We should certainly don't do all of them in one issue and just list here all the different issues.

We maybe could also think of making some of these methods protected at the same time.

How should it be split up? One issue per class?

Here are the methods in question:

EDIT: Removed them from here now that they're in the issue summary. duplication--

Perhaps it would be useful to add a table to the issue summary with the proposed replacement names, we'll want to get them right.

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

That's all? Well, I've updated the issue summary with them.

That's quite helpful; thanks @TravisCarden and @tim.plunkett!

Just to reiterate, we don't want to start on this yet, due to the high volume of patches at present.

Views apparently also has some methods prefixed with underscores, violating the OO standards:

Protected or private properties and methods should not use an underscore prefix.

Let's add that in scope here too.

Well we could use something like helperTestFooBar?

I personally am pretty anti-"helper"; the word almost always obscures rather than clarifies the purpose of the given function, and is superfluous.

just throwing more ideas:

* subTestFoo
* fastTestFoo
* spliTestFoo
* singleTestFoo
* ponyTestFoo

Let's get a list of them first, see if they all have non-underscore methods already taking their non-underscore name, and rename them case-by-case if there are few enough of them so that we can make the names more descriptive.

Alternately, ponyTestFoo() sounds like a pretty good suggestion. ;)

This issue doesn't catch all of the methods that need to be renamed; e.g., those in #1861838: Change notice: Clean up the various Views field rendering methods.

Project:Drupal core» Views
Issue summary:View changes

Added method list to issue summary.

Issue summary:View changes

Adding pre_render() to the list of methods.

Issue summary:View changes

third column for issue link

Project:Views» Drupal core
Assigned:Unassigned» benjifisher
StatusFileSize
new9.39 KB

The attached file lists all the methods with underscores in their names, organized by subdirectory of core/modules/views/lib/Drupal/views/Plugin/views/ and files in each subdirectory. For example,

▸ display_extender/
    DefaultDisplayExtender.php
    DisplayExtenderPluginBase.php
      pre_execute

indicates that display_extender/DefaultDisplayExtender.php has no such methods, and display_extender/DisplayExtenderPluginBase.php defines the method pre_execute().

I generated the list using Exuberant ctags and vim. When there are hundreds of methods involved, I think a little automation is more reliable than doing it manually.

I am assigning the issue to myself while I work on rewriting the issue summary.

Project:Drupal core» Views
Issue summary:View changes

markup fix

Issue summary:View changes

Add a complete list of methods that need to be replaced, based on the file attached to Comment #13.

Project:Views» Drupal core
Assigned:benjifisher» Unassigned

I finished editing the issue summary. @tim.plunkett, how did you get the original list of methods to be renamed? I am more than a little worried that my list is so different from yours.

I think mine was a sloppy grep. If your list is bigger you are right.

Status:Postponed» Active

Excellent, thanks @benjifisher!

Marking active (meant to do this yesterday).

I do not understand the point of the rule quoted in #7. It seems redundant, given this rule, from earlier in the same list:

Methods and class properties should use lowerCamel naming.

When preparing the list in #13, I only looked for methods, not properties. In argument/Date.php I notice

<?php
 
var $option_name = 'default_argument_date';
?>

I did not know what the var was doing, so I looked it up: http://us2.php.net/var

Note: The PHP 4 method of declaring a variable with the var keyword is still supported for compatibility reasons (as a synonym for the public keyword).

This looks to me like grist for a related task.

Project:Drupal core» Views
Issue summary:View changes

Oops, I used the wrong table. See previous commit message.

Project:Views» Drupal core

I added to the summary a link to a pre-filled node form for sub-issues. Are these ready to start tackling, or do the new names still need to be evaluated? The summary says, "#11 suggests that we consider changing to more descriptive names instead of mechanically replacing "camel_case" with "camelCase"."

#18: I'd say all of the method names make sense, except for op_*. I'd give my suggestion for a rename, but I don't have a good idea what the methods are.

I guess op_{foo} should maybe converted to query{foo}?

Project:Drupal core» Views
Issue summary:View changes

Added a link to create new sub-issues.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

See the text file attached to #13: the op_* methods come from Combine.php, Date.php, GroupByNumeric.php, InOperator.php, ManyToOne.php, Numeric.php, and String.php, all under filter/.

The code in Combine.php contains

<?php
 
// By default things like op_equal uses add_where, that doesn't support
  // complex expressions, so override all operators.
 
function op_equal($expression) {
   
$placeholder = $this->placeholder();
   
$operator = $this->operator();
   
$this->query->add_where_expression($this->options['group'], "$expression $operator $placeholder", array($placeholder => $this->value));
  }
?>

I looked as a few more, and they seem similar. So these are filter objects, and the op_* methods impose conditions. I am no expert in naming conventions, but I think that whereEqual() makes more sense than queryEqual(). Isn't it an implementation detail that the methods all (or at least the ones I checked) add queries?

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Added issue for wizard_form().

Issue summary:View changes

Oops. Wrong row. :)

Project:Views» Drupal core

Based on all this feedback, I went ahead and took a stab at renaming the op_{foo} functions in the summary.

heddn:

Good, I like "add". It looks as though you took some care to see what the functions actually do. For example, changing op_not() to addNotLike(). Thanks!

Aside: looking at the two implementations of op_not() (Combine.php and String.php) I see several other duplicated methods. Once again, grist for another task!

One thing worries me. Is there any place in the Views code that does something like

<?php
// hypothetical snippet
$method = 'op_' . $this->operator;
$this->filter->$method($this->parameter);
?>

I did a quick grep in the Views module, and there are no instances of "op_" as a complete word, so maybe not.

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Issue summary:View changes

updating instructions for creating issues

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary

Project:Views» Drupal core
Assigned:Unassigned» benjifisher

I am going to add some sub-issues.

Project:Drupal core» Views
Issue summary:View changes

get_title

Project:Views» Drupal core
Assigned:benjifisher» Unassigned

Done editing the summary for now.

Project:Drupal core» Views
Issue summary:View changes

Add some more sub-issues.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

updating summary

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

FYI: I added an "Access" column to the table in the summary to indicate whether new methods should be public, protected, or private. That way maintainers can get that decision out of the way all in one place instead of having the same discussion in every single sub-issue.

Thanks @heddn and @benjifisher for create the sub-issues.

@TravisCarden, I am working on a few sub-issues within the table above. For now, should I be making the functions public?

Project:Drupal core» Views
Issue summary:View changes

Added "Access" column to indicate whether new methods should be public, private, or protected.

Issue summary:View changes

add more sub-issues: has_* through load_*

Issue summary:View changes

updating summary

Issue summary:View changes

Added issues

Issue summary:View changes

Corrected issue number for useStringGroupBy()

Issue summary:View changes

Add @.

Issue summary:View changes

Adding @ signs to issues.

Issue summary:View changes

2002986 - jastraat

Issue summary:View changes

get_plugin

Issue summary:View changes

added links to issues

Issue summary:View changes

added issue link

Issue summary:View changes

added links to issues

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

get_render_tokens, fixing stuff

Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

@elvis2: @dawehner, @xjm, and co. will ultimately answer the question of access per method, but until they get to it public is probably a good default.

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

get_row_class

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

get_sort_name

Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

#2000344: Rename get_access_callback() to getAccessCallback() is a good example of an already completed/closed ticket that could be used an example.

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Adding issue [#20023410] link

Issue summary:View changes

Linked to issue 2003412

Issue summary:View changes

adding op_between issue

Does anyone have any guidance on testing patches on these issues? I'm assuming the following:

  • Run the Views tests and confirm that nothing fails.
  • Search the code base and confirm that all instances of the function name have been updated.
  • Review the patch and confirm that no other function names have been changed. I don't know that any of these class methods share a name with global functions, but if they do, we don't want to change the name on that function.
  • Check access on the method (public/private/protected)

What am I missing?

Project:Views» Drupal core

#30

  • Yes
  • Yes
  • Yes

You aren't missing anything. It really should be that simple.

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Issue summary:View changes

operatorForm

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

addStartsWith

Issue summary:View changes

Rename Views method op_simple() to addSimpleQuery()

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

@BrockBoland

Be sure to check that there is an access modifier for changed functions as mentioned in comment #28.
A lot of the patches seem to forget that (including myself ;))

Thanks oenie, updated the list.

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Adding issue for ophelper

Issue summary:View changes

Adding @ signs for issues.

Issue summary:View changes

adding ticket 2003580

Issue summary:View changes

updating summary

Issue summary:View changes

Added assignments to issue displays.

Issue summary:View changes

Added the access modifier details for #2002274

Project:Views» Drupal core

I assume when our patches pass for each of the rename issues, we are supposed to come back and edit this issue, to put in the "access" modifier that was used in the patch?

Project:Drupal core» Views
Issue summary:View changes

Added access details for #2002340

Issue summary:View changes

Added access to #2002272

Issue summary:View changes

Added access info for #2002344

Issue summary:View changes

Added access info for #2002276

Issue summary:View changes

Added access info for #2002280

Issue summary:View changes

Added access info for #2003464, #2003312, #2003316

Issue summary:View changes

Fixed html typo that I created on last revision...

Issue summary:View changes

Updated method access based on patches - for issues #2001320, #2001330

Issue summary:View changes

Updated access column for addTag(), based on #2002338 patch.

Project:Views» Drupal core

No, it's sort of the other way around: the table here indicates what the access should be in the patches written for those other issues. As noted in comment #28, assume public if no value is specified in the table here.

@BrockBoland, @elvis2: in my patch reviews i suggested protected only when it looked when the patch methods seemed to be called on $this instances, public otherwise (which is most cases)

If someone would correct me on this approach, feel free.

Project:Drupal core» Views
Issue summary:View changes

Updated wizardForm() access info based on #2002928

Project:Views» Drupal core

Several of these views patches are failing due to : #1987952: Blocks are not rendered in order by weight. If you get a block order test that randomly fails, then this issue is probably why.

@heddn: Could that be fails pre 25/05 ?
That's when alexpott reverted the problematic commit. (see comment #17 on the issue you mentioned)
Rescheduling a test should help there (no commits have been made on the problem since)
I've done that with some of the issues, and that helped.

@oenie yes, after 25/05 things would start working.

This sub issue has an old comment left around. I am not sure what to do with it.
http://drupal.org/node/2002272#comment-7461844

Should I remove it? It looks like it might be from a long time ago...

Project:Drupal core» Views

Just resubmitting so the page cache will clear and status will show properly.

Project:Views» Drupal core

@elvis2: I'd avoid adding questions about specific changes here, to keep this issue from becoming too scattered.

Project:Drupal core» Views

Just resubmitting so the page cache will clear and status will show properly.

Issue summary:View changes

trigger update

Issue summary:View changes

trigger update

Issue summary:View changes

trigger update

Issue summary:View changes

Update list

Issue summary:View changes

Update list

Issue summary:View changes

specifying protected access for opNot*With

Project:Views» Drupal core

I have seen @webchick move some renaming issues to views 8.x.3.x iq. To create that many change notice is not good IMHO.
So can we create a single change notice for all the methods?
Something like this.
All the Views method names are converted to camelCase. So, foo_the_bar() becomes fooTheBar().
Detail list is below

From To Access
foo_the_bar() fooTheBar() public/protected

@jibran, yes, we'll create one single change notice for all of them.

In #11 and #20-#23 above, we discussed changing some method names beyond converting camel_case to camelCase. I do not see any further discussion on this page, but it looks as if that idea was abandoned.

The change notice should make sure to list exceptions, if any, to the renaming rule. The table in the issue summary is not currently up to date, although the issue titles (mostly? all?) reflect the final decision.

Project:Drupal core» Views
Issue summary:View changes

Update

Issue summary:View changes

Add a second issue link for op_not_ends() since the one listed was closed as a duplicate.

Issue summary:View changes

Update

Issue summary:View changes

Update list

Issue summary:View changes

update

Issue summary:View changes

Update list, final

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Project:Views» Drupal core

Looks like we're almost done here -- just #2003366: Rename Views method pre_render() to preRender() plus the followup #2020377: Rename Views method opNotEnds() to opNotEndsWith(). to go. Awesome work everyone!

When those last two are fixed, we'll create a single change notification in Views (not core) for all the method renames.

Oh, and I updated the table.

Looks like we missed these as well:

  • CachePluginBase::post_render()
  • ExposedFormPluginBase::post_render()
  • ManyToOneHelper::add_filter()
  • ManyToOneHelper::summary_join()

Project:Drupal core» Views
Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Added follow up issue.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Just did another commit spree of the remaining few RTBC issues. I *believe* that the only one left now is #2003366: Rename Views method pre_render() to preRender()!

Status:Active» Fixed

I guess that this is fixed now. Yay!

Title:[META] Rename Views methods to core standards[Change notice] [META] Rename Views methods to core standards
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Documentation
Status:Fixed» Active
Issue tags:+Needs change record

Hooray!

We need a change notification, though.

Wow, impressive work by the community and the comitters!

#2056943: Convert render_link to renderLink was missed, for whoever writes the change notice.

Issue summary:View changes

added summary_join() add_filter() & post_render()

That was just committed, so this should be good to go now!

Assigned:Unassigned» iflista

Working with change notice.

Issue summary:View changes

Add render_link to renderLink to the table.

Assigned:iflista» Unassigned

Unassing to let people work into it.

Assigned:Unassigned» eddib

NOTE: this is work-in-progress.
I still need to check if all patches have been committed.

Change overview

  • The Views method names have been renamed and now use camelCase() instead of underscore_separated().
    The Views method names are now in compliance with the OOP standards.
  • Obsolete methods have been removed (see table at the bottom).

Renamed methods

The following table gives an overview of the renamed methods.
The table lists the old and new method name and the access property of the method (where available):

From To Access
add_additional_fields() addAdditionalFields()
add_field() addField()
add_groupby() addGroupby() public
add_having() addHaving()
add_having_expression() addHavingExpression() public
add_filter() addFilter() public
add_orderby() addOrderby() public
add_relationship() addRelationship() public
add_self_tokens() addSelfTokens() protected
add_signature() addSignature() public
add_table() addTable()
add_tag() addTag() public
add_where() addWhere() public
add_where_expression() addWhereExpression() public
adjust_join() adjustJoin()
advanced_render() advancedRender()
aggregation_method_distinct() aggregationMethodDistinct()
aggregation_method_simple() aggregationMethodSimple()
allow_advanced_render() allowAdvancedRender()
alter_display_options() alterDisplayOptions()
alter_subquery_condition() alterSubqueryCondition()
attach_to() attachTo()
block_display_options() blockDisplayOptions()
build_condition() buildCondition()
build_display_options() buildDisplayOptions()
build_filters() buildFilters()
build_form() buildForm()
build_form_style() buildFormStyle()
build_group_form() buildGroupForm()
build_group_options() buildGroupOptions()
build_group_submit() buildGroupSubmit()
build_group_validate() buildGroupValidate()
build_sort() buildSort()
build_sort_post() buildSortPost()
build_sorts() buildSorts()
cache_expire() cacheExpire()
cache_flush() cacheFlush()
cache_get() cacheGet()
cache_set() cacheSet()
cache_set_expire() cacheSetExpire()
cache_start() cacheStart()
can_build_group() canBuildGroup()
can_group() canGroup()
check_access() checkAccess()
clear_fields() clearFields()
click_sort() clickSort()
click_sortable() clickSortable()
compile_fields() compileFields()
condition_namespace() conditionNamespace()
convert_exposed_input() convertExposedInput()
create_view() createView()
default_access_denied() defaultAccessDenied()
default_action() defaultAction()
default_actions() defaultActions()
default_argument_form() defaultArgumentForm()
default_default() defaultDefault()
default_display_filters() defaultDisplayFilters()
default_display_filters_user() defaultDisplayFiltersUser()
default_display_options() defaultDisplayOptions()
default_display_sorts() defaultDisplaySorts()
default_display_sorts_user() defaultDisplaySortsUser()
default_empty() defaultEmpty()
default_ignore() defaultIgnore()
default_not_found() defaultNotFound()
default_summary() defaultSummary()
default_summary_form() defaultSummaryForm()
document_self_tokens() documentSelfTokens()
element_classes() elementClasses()
element_label_classes() elementLabelClasses()
element_label_type() elementLabelType()
element_type() elementType()
element_wrapper_classes() elementWrapperClasses()
element_wrapper_type() elementWrapperType()
ensure_path() ensurePath()
ensure_table() ensureTable()
even_empty() evenEmpty()
exception_title() exceptionTitle()
execute_count_query() executeCountQuery()
exposed_filter_applied() exposedFilterApplied()
exposed_form_alter() exposedFormAlter()
exposed_form_submit() exposedFormSubmit()
exposed_form_validate() exposedFormValidate()
exposed_translate() exposedTranslate()
gather_headers() gatherHeaders()
get_aggregation_info() getAggregationInfo()
get_argument() getArgument()
get_channel_elements() getChannelElements()
get_current_page() getCurrentPage()
get_default_argument() getDefaultArgument()
get_description() getDescription()
get_elements() getElements()
get_entity() getEntity()
get_entity_tables() getEntityTables()
get_field() getField()
get_field_alias() getFieldAlias()
get_field_value() getFieldValue()
get_formula() getFormula()
get_items() getItems()
get_items_per_page() getItemsPerPage()
get_join_data() getJoinData()
get_lifespan() getLifespan()
get_non_aggregates() getNonAggregates()
get_offset() getOffset()
get_pager_id() getPagerId()
get_pager_total() getPagerTotal()
get_plugin() getPlugin()
get_render_tokens() getRenderTokens()
get_row_class() getRowClass()
get_sort_name() getSortName()
get_table_info() getTableInfo()
get_temporary_view() getTemporaryView()
get_title() getTitle()
get_token_values_recursive() getTokenValuesRecursive()
get_total_items() getTotalItems()
get_value() getValue()
get_value_options() getValueOptions()
get_where_args() getWhereArgs()
group_form() groupForm()
group_multiple_exposed_input() groupMultipleExposedInput()
has_default_argument() hasDefaultArgument()
has_more_records() hasMoreRecords()
instantiate_view() instantiateView()
is_exception() isException()
is_value_empty() isValueEmpty()
items_per_page_exposed() itemsPerPageExposed()
left_query() leftQuery()
load_entities() loadEntities()
mark_table() markTable()
offset_exposed() isOffsetExposed()
op_between() opBetween()
op_contains() opContains()
op_empty() opEmpty()
op_ends() opEndsWith()
op_equal() opEqual()
op_helper() opHelper()
op_longer() opLongerThan()
op_not() opNotLike()
op_not_ends() opNotEndsWith() protected
op_not_starts() opNotStartsWith() protected
op_regex() opRegex()
op_shorter() opShorterThan()
op_simple() opSimple()
op_starts() opStartsWith()
op_word() opContainsWord()
operator_form() operatorForm()
operator_options() operatorOptions() public
operator_submit() operatorSubmit()
operator_validate() operatorValidate()
operator_values() operatorValues()
page_display_options() pageDisplayOptions()
page_feed_display_options() pageFeedDisplayOptions()
post_render() postRender()
pre_execute() preExecute()
pre_render() preRender()
prepare_filter_select_options() prepareFilterSelectOptions()
process_summary_arguments() processSummaryArguments()
queue_table() queueTable()
reduce_value_options() reduceValueOptions()
render_altered() renderAltered()
render_as_link() renderAsLink()
render_exposed_form() renderExposedForm()
render_fields() renderFields()
render_grouping() renderGrouping()
render_grouping_sets() renderGroupingSets()
render_items() renderItems()
render_link() renderLink()
render_text() renderText()
render_textarea() renderTextarea()
render_trim_text() renderTrimText()
reset_form() resetForm()
restore_headers() restoreHeaders()
retrieve_validated_view() retrieveValidatedView() protected
row_style_options() rowStyleOptions() protected
sanitize_columns() sanitizeColumns()
set_argument() setArgument()
set_breadcrumb() setBreadcrumb()
set_count_field() setCountField()
set_current_page() setCurrentPage()
set_distinct() setDistinct()
set_group_operator() setGroupOperator()
set_items_per_page() setItemsPerPage()
set_limit() setLimit()
set_offset() setOffset()
set_override_options() setOverrideOptions()
set_validated_view() setValidatedView()
set_where_group() setWhereGroup()
show_build_group_button() showBuildGroupButton()
show_build_group_form() showBuildGroupForm()
show_operator_form() showOperatorForm()
show_sort_form() showSortForm()
show_value_form() showValueForm()
sort_options() sortOptions()
sort_submit() sortSubmit()
sort_validate() sortValidate()
store_group_input() storeGroupInput()
summary_argument() summaryArgument()
summary_basics() summaryBasics()
summary_join() summaryJoin()
summary_name() summaryName()
summary_name_field() summaryNameField()
summary_query() summaryQuery()
summary_sort() summarySort()
title_query() titleQuery()
tokenize_value() tokenizeValue()
update_page_info() updatePageInfo()
use_count_query() useCountQuery()
use_pager() usePager()
use_string_group_by() useStringGroupBy()
uses_breadcrumb() usesBreadcrumb()
uses_exposed() usesExposed()
uses_tokens() usesTokens()
validate_argument() validateArgument()
value_form() valueForm()
value_submit() valueSubmit()
value_validate() valueValidate()
wizard_form() wizardForm() public
wizard_submit() wizardSubmit() public

Removed methods

The following table list the removed methods and gives a short description on why there were removed.
A link to the issue discussing the removal is also available:

Method Reason for removal Related issue
set_header() The views method set_header() is not used and thus obsolete. #2003284: Remove Views method set_header()
get_access_callback() Views has been updated to use the D8 routing system #1800998: Use route system instead of hook_menu() in Views

@rteijeiro sorry for not making a post with progress, I suddenly got into hospital. I reviewed all patches, everything is updated. There are few private methods that are not camelCase but they created not in views so probably it's a task for another issue. As far as I saw that was the only problem with naming conventions. Everything in patches is correct. There still some work needed for change record, while I was doing it browser crashed few times due to huge amounts of related issues I have to add so there are few duplicates in change record, it has to be fixed.

@eddib sorry you started redoing the same work as I did, you can review and compare issues from issue summary and change record to find and remove duplicates.

Issue summary:View changes

fixed mistake