Once your breakpoints are defined in your themes .info file and the module picks them up, they cannot be modified or deleted!! Even if modifying or deleting them in the .info file doesnt get reflected in the module, they are there for good when initially defined. Even disabling, uninstalling then enabling the module doesnt help.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | my_breakpoints.zip | 2.29 KB | attiks |
Comments
Comment #1
attiks commentedWe need to backport the 'reload from theme' functionality from the Drupal 8 version, see http://drupalcode.org/project/breakpoints.git/blob/refs/heads/8.x-1.x:/b...
But uninstalling should work, can you check that the breakpoints table gets deleted after uninstalling?
Comment #2
hass commentedI have added breakpoints to my themes. Cleared all cached several times and they are still not loaded. What's wrong here?
Comment #3
attiks commentedcan you try disabling your theme, clear all caches and enable it again.
Comment #4
hass commentedIs this the way how it is designed to work?
Comment #5
attiks commented#4 breakpoints module acts on hook_themes_enabled and that's the only moment when theme breakpoints are read.
Comment #6
hass commentedOther theme setting are also refreshing if I change them and clear the caches. The current logic is not ok. Themes are changing and breakpoints may too.
Comment #7
attiks commentedI never said the logic was ok, see #1 the code exists in the 8.x branch, it needs a backport to D7. Patches are welcome.
Comment #8
hass commentedAside, my themes are configurable via theme setting. Therefore the breakpoints are dynamic like page widths, sidebar widths, columns and so on and so on. Just as a side note that is not related here - I'm adding css files, js and settings also dynamically to the theme via template.php. Need the same for breakpoints...
How is this handled by D8 and D7 module here? Is there a info hook that breakpoints module calls to get the current breakpoints?
Comment #9
attiks commented"Is there a info hook that breakpoints module calls to get the current breakpoints?" No, breakpoints are imported when a theme or module is enabled, but you can create custom breakpoints (and groups) that get stored inside database/config.
There's a branch for Drupal 8 containing the new UI: http://drupalcode.org/project/breakpoints.git/shortlog/refs/heads/core_ui
Related issues:
#1775302: Do a UX review of Breakpoint module
#1813126: Awesome breakpoints & gridbuilder UI
Comment #10
attiks commented#8 You want to manage your breakpoints on the appearance page? Or do you want to export your breakpoints to js?
Comment #11
hass commentedThe themes allow users to change the width, columns widths and number of columns, min width, etc on appearance page. With the values they configured I need to calculate and set the breakpoints based on their settings. They will not configure the breakpoints as I know, where they are based on their settings. Therefore this values need to be "refreshable".
Comment #12
attiks commented#11 So you to create them on the fly, since breakpoints and groups are exportable you could implement hook_default_breakpoints and hook_default_breakpoint_group, I attached a feature containing the export of a group.
Only thing you probably have to do is clear the cache using ctools_export_load_object_reset after the theme settings are saved.
Comment #13
attiks commentedfeel free to re-open if needed
Comment #14
hass commentedHas the backport from #1 done?
Comment #15
attiks commentedEach theme settings page should have a new button to reload
Comment #16
hass commentedThis is worse usability. If I open the appearance page I expect it is up to date all times. After I press save, too. Everything else is a usability fail.
Comment #17
attiks commentedAs said in #13, feel free to re open this issue and feel free to submit a patch.
Comment #18
hass commentedComment #19
DrupalNovice commentedHello,
I am facing the same problem. Fresh install of Drupal 7. I've defined the breakpoints in my themes .info file like so:
I've tried changing the default theme back and forth, cleared the caches, disable/enable the module, but the breakpoints are still not loaded from the .info file to the UI.
Comment #20
attiks commentedAt the bottom of the theme settings page you should see a new button to reload the theme info, do you see it?
Comment #21
DrupalNovice commentedAh, how did I miss that.. now it works perfectly.
Thank you for this nice module :)
Comment #22
hass commentedComment #23
joachim commented> At the bottom of the theme settings page you should see a new button to reload the theme info, do you see it?
I see it, but it's not easily discoverable.
After adding or changing breakpoints in my theme info file, I expected one of the following to cause them to get noticed:
- refreshing the breakpoint admin page
- clearing the cache
Neither does it.
A mention of where to find this button in the help text on admin/config/media/breakpoints would suffice to fix this UX bug.
Comment #24
attiks commenteddocs will we fixed by #2075595: Documentation needs clarification
Comment #25
hass commentedThe bug is not fixed. Documenting a bug does not fix it.
Comment #26
attiks commentedTHis is fixed a long time ago, only thing left is adapting the documentation.
Comment #27
hass commentedThere was not commit message on the case. Can you add the commit link, please?
Comment #28
jelle_sfrom #23:
In the latest dev, breakpoints are reloaded from theme .info files when the cache is cleared (420b57c)