Wrong "Unknown" pieces in label path due to bad hierarchy computation and may result in infinite loop [#1891082]

I created a 3 level hierarchy in my metatag setup and I saw the third level labels always began with "Unknown: Unknown: level label".

Debuggiing I found the bug
when looking for the label for "a:b:c" it removes c and then ask for parents finding
"a:b" and "a", then it runs an implode and looks for a label for "a:b:a" that is wrong.

Also, if you define a 4th level then this lookup results in an infinite loop and an outofmemory error and you have to manually remove the "4 level" instance definition from the DB in order to be able to use the site again.

Comment	File	Size	Author
#6	1891082-fix-config-label-recursion.patch	2.38 KB	dave reid
#5	1891082-fix-config-label-recursion.patch	2.43 KB	dave reid
#3	1891082-fix-config-label-recursion.patch	2.43 KB	dave reid
#1	metatag-oom_recursion_and_unknown_label-1891082-1.diff	586 bytes	bago

Comments

Comment #1

bago commented 17 January 2013 at 11:15

Status:

Active

» Needs review

Status	File	Size
new	metatag-oom_recursion_and_unknown_label-1891082-1.diff	586 bytes

Here is my patch.

Comment #2

bago commented 17 January 2013 at 11:25

Priority:

Normal

» Major

While I fixed this issue for the "unknown" part I move this to major because this fixes also the infinite loop => out of memory => broken site issue when using 4 level instances (declared by custom/third party modules).