[Meta] Features and Changes for Entityform 2.x

Upgrade path for Webform?

@DamienMcKenna, couldn't you think of something a little harder? ;)

I think converting Webform Components to Fields would be pretty hard. I think if this something that was really needed then it would better in a separate module. That way it wouldn't have to hold up the release of Entityforms 2.x.

If it was done as separate module, "Webform to Entityform"(W2E or something) it should be dependent on a another new module, "Webform Component to Field"(WFC).
That way other modules or custom code could use WFC to convert Webforms to other entities, Content Types or Profile2 Types, etc.

This would probably only work with simplier Webforms and because there are so many modules that integrate with Webforms it would probably be just geared to base Webforms module.

Maybe it should a separate issue. If you or someone else is interested in taking this on I would be interested in helping.

@gmclelland, interesting. I am not sure would be possible b/c I want the Entityforms Type editor to be able to just switch submission Views per EntityForm type without having to have access to the Views UI etc.

Right now there is VBO integration if the module is enabled but the Views will still work if VBO is not installed, not a dependency.

Remove Rules dependence

Probably make a entityform_rules submodule that would have all the current functionality.
That way people could use Entityforms if they didn't want to install Rules and didn't need any of the Rules functionality. Probably have notices in the current settings to say "Enable Entityform Rules to ....."

I am working on new module that will allow taking out the Rules dependence of the this module

Entity Rules allows triggering of Rules components on entity events, i.e. create, update, delete. It will also have Validation and Access events for modules that provide info about their entity add/edit forms.

This will basically allow the current functionality of triggering Rules but from a separate Rules tab for each bundle.

It is a work in progress right now but you can try via git clone.

Does the submitted values have any sort of access system, perhaps similar to the node access system?

No there is no advanced access system. I don't think this would be added. The problem gets into recreating all the features that the Node system has. This module is geared towards entityform submissions not being "content".

If someone finds another contrib module that implements an entity access api I would consider integrated support but I don't think it should be created by this module.

1 option would be to add a drupal_alter call in entityform_access. So that any module could alter access. Workbench Moderation does something like this. But I don't think this would effect access in Views.

added linked to new issue

Ok, I have started working on 7.x-2.x. Removed all references to Rules for a start.

See #1864248: Remove Rules requirement

added Entity Rules reference

Moved Entityform Nodes submodule - to Not Likely. This could be done in another module

Reference only for Entityform Types

Add option to restrict submitting a particular Entityform Type to only work when it is used as Entity Reference. This would make it possible for Entityform Nodes module to restrict the viewing of the Entityform Type to only work when it is shown with the node(no direct url to the Entityform Type submit page).

I am thinking this feature could be changed to "Provide Submit Page" which would default to true.

The benefit of setting this to FALSE would be that you could link it to a node(or other entity) via Entity Reference and then access to submitting the Entityform could be totally controlled by access to the Node which can have more complex access control.

Any thoughts?

Regarding #13 to #18

I have a patch in #1937526: Extend submission access system

That adds hook_entityform_access_alter and needs review.

moved Entityform Node section

Removing clone issue b/c is Entity API issue

I am looking for help on this issue #1848018: Add i18n support for Label and other property translation (+ entityform name)

If I could get some help then i18n support could be added for all entityform type text properties.

add i18n issue link

New feature #1973954: Create "Preview Form" admin tab

Updated issue summary.

Move issue to postponed

Ok I have update the issue summary.

Thing are getting close.

Here are all remaining issues

So you are interested in geting a 2.0 alpha take a look at these issues.

I re-wrote Entityform Notifications.

It is basically not just exported Rules that work with the new Entity Rules module.

The Rules use the module Entity To Text module to include in the submission data in the emails.

I also took the tokens logic from Entityform b/c it is now Entity To Text(and works with any entities).

@joachim, thanks for the tip about Session API.

Maybe we should use it if it is installed but not a make it a dependencies. I am trying to limit dependency.

My idea is to have some sort of Anonymous user tracking setting. Then if the Session API is not enabled just provide a notice that it need to track anonymous users.

I don't want to make it a dependency b/c nobody has actually asked for this feature(maybe shouldn't be added at all?).

@joachim and anybody interested in anonymous submission tracking.

I am going to postpone this because nobody has ever asked for this feature or complained that it wasn't there.

It probably shouldn't be to hard to do in another contrib module especially now that we have an alter hook for submission access(to stop an anonymous user from submitting 2x).

Final issue before the release of 7.x-2.0 #2134619: Upgrade process for upgrading Rules from 1.x to 2.x

@gmasky for #1 Entityform Submissions don't have a "published" property. If you need that you should think about using nodes.

#2 you would have to do my Rules or Custom code. but this would be a separate issue.

@gmasky can you make a separate issue if you want support on this? This is not what this issue is about.

Also do a search in the issue queue first I know some other people had similar questions.

Thanks

Ok someone needed anonymous user tracking and was able to fund the development.

I am working in another branch and it will probably be a submodule. You can read about it here:

#2181691: Allow Anonymous users to edit Entityform Submissions

Any help testing would be great!

@tsvenson thanks for the feedback. Yes Rules is not necessary for 2.x unless you are using Entityform Notifications.

The project page and documentation could use updates. I would appreciate any help on docs and if someone has better wording for project page they can create an issue with the text.

Thanks