Hello

I've done some cleanup on the code:
- removed searchbox from pane-heade & preprocess function
- added some comments

CommentFileSizeAuthor
pe-cleanup.patch2.53 KBlpalgarvio

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Needs review
bigbaldy’s picture

bigbaldy commented

I've looked at the code in the patch and applied it. It seems to resolve the issues addressed. Also, fixes the issue in https://drupal.org/node/2030157#comment-7612689.

iztok’s picture

iztok commented

Applied the patch on dev branch and it fixes the issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes

Seems reasonable. I'll review it shortly.

  • Commit ec9f5d5 on 6.x-1.x by DamienMcKenna: 
    Issue #1918756 by lpalgarvio: Removed a duplicate $front_page from the...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks.

  • Commit e5e1fa1 on 7.x-1.x by DamienMcKenna: 
    Issue #1918756 by lpalgarvio: Removed some extra remnants of the defunct...

  • Commit 0a42fe5 on 6.x-1.x by DamienMcKenna: 
    Revert "Issue #1918756 by lpalgarvio: Removed a duplicate $front_page...

  • Commit 0e14bb7 on 6.x-1.x authored by lpalgarvio, committed by DamienMcKenna: 
    Issue #1918756 by lpalgarvio: Removed a duplicate  from the header tpl.

  • Commit 03504e3 on 7.x-1.x by DamienMcKenna: 
    Revert "Issue #1918756 by lpalgarvio: Removed some extra remnants of the...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I've (reverted and) committed this one again in order to fix the authorship.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.