Needs review
Project:
Disable Term Node Listings
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
7 Mar 2013 at 13:46 UTC
Updated:
2 Jul 2020 at 06:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
blacksnipe+1! Did you manage to fix it, Thamas?
Comment #2
thamasUnfortunately not. If I was able I had sent a patch… :(
Comment #3
modestmoes commentedBoth the i18n_taxonomy module and disable_term_node_listing module use the same approach. My guess is that the hook_menu_alter functions get called alphabetically and i18n_taxonomy rewrites the _alter that is done in disable_term_node_listing.
An alternative module that does something similar but doesn't conflict.
https://drupal.org/project/taxonomy_display
Comment #4
chris.smith commentedCame across this issue while working on a client project. Here is a patch that moves the menu_alter hook to the last position, so it executes after i18n. Implements hook_module_implements_alter.
Comment #5
strykaizerI can confirm #4 solves the incompatibility with i18n_taxonomy.
Please commit ;)
Comment #6
kpaxman commentedI am not using the i18n_taxonomy module, but this module wasn't working at all for me, similar to this issue. Installing the patch from #4 fixed it.
Comment #7
strykaizerHmm, seems like this module also uses the wrong Term name language for translated terms. (drupal_set_title on line 37)
Comment #8
sheijtel commentedWe use i18n_taxonomy and the path from #4 has fixed this issue.
Comment #10
akeemw commentedExperimental support for i18n Taxonomy has been committed to 7.x-1.x-dev branch but needs review an testing before I can release it as a new version.
Comment #11
Ultragiga commentedI can hereby confirm that patch #4 works. The thing to remember is that if you want to disable taxonomy term pages is to set the Display 404 or 403 Page option because setting the Disable node listing for all terms has seemingly no effect at all.
Cheers for submitting this wonderful patch!
Comment #12
marcvangendThis solution does not really work, at least not with localized terms. The patch only makes sure that this module takes priority over i18n_taxonomy. What we (or at least: I) really need, is that the two modules play nice together.
The easiest way to achieve this, is to make Disable Term Node Listings translate/localize the term before doing anything else with it, just like i18n_taxonomy_term_page() does. See the patch attached; this should be applies in combination with the patch from #4.
Maybe, a better approach (but a much larger change to this module) would be for Disable Term Node Listings to not define its own menu callback, but only alter the page content as built by other modules, removing the listing.
Comment #13
marcvangendPS.
This comment was copied from the API documentation, but "my_module_rdf_mapping" is incorrect of course. It should refer to the disable_term_node_listings_menu_alter().
Comment #14
eeg commentedThe patch #4 can cause problems with other modules, for example Elysia Cron, that don't expect an empty menu item array in their menu_alter implementation. Therefore I've attached a patch for the current dev branch that uses a complete menu item array, just with the items unset that need to be checked for alterations.
Comment #15
miiimoooHere is a different patch that uses `hook_module_implements_alter`