[D7] Phased Contest

hi

Autometed Review:

Check this url http://ventral.org/pareview/httpgitdrupalorgsandboxpieisgood1937046git

Manual Review:

• In your module file line no.34 Hook is hook_form_FORM_ID_alter but your comment is hook_form_alter.
• Insted of use img tag it would be nice if you used theme_image hook.
• t() is missing for description of form field in your phased_contest.proprties.inc file.

Thanks,
Mayank Kamothi

Hi
Manual Review

1. It should eliminate persistent variables on hook_uninstall
2. Add the README.txt
3. It would be great if you could create a file *.api.php to document module's hooks

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and put yourself on the PAReview: review bonus high priority list. Then I'll take a look at your project right away :-)

Hi PieIsGood,

The module seems like it could be useful but has some UI problems (possibly form_builder bugs) that make it difficult to test.

The module has a lot of dependencies (more than 10) so you might consider listing them on your project page as this may affect some people's decision about whether to use the module.

In the module file, consider using module_load_include() to include 'phased_contest.features.inc'.

Incomplete comment at line 62 of the module file.

At line 312 of the module file, you add CSS, but if I'm not mistaken I think you could also add it in phased_contest_form_phased_contest_entries_node_form_alter() by setting $form['#attached'] like in this example...

$form['#attached']['css'] = array(
  drupal_get_path('module', 'ajax_example') . '/ajax_example.css',<br/>
);

At line 388 and 391 I don't think you need that equals sign. That's the default.

At line 328 please write a clearer comment especially when you are highlighting something that you think might not work.

In the function doc blocks consider indicating when you are implementing _preprocess_. I don't know the standard way of doing that but it seems like a good idea.

You have untranslated strings at lines 223 and 232.

Line 422 is another place where your comment indicates you think something is inadequate, but you don't explain why.

Untranslated string at line 433.

I'm getting this error...

Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /var/www/drupal_fresh/includes/common.inc).
    Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /var/www/drupal_fresh/includes/common.inc).
    Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /var/www/drupal_fresh/includes/common.inc).
    Notice: Undefined index: #prefix in form_builder_field_field_widget_form() (line 153 of /var/www/drupal_fresh/sites/all/modules/form_builder_field/form_builder_field.module).

...at node/add/phased-contest.

I don't know if it's a bug in your module or form_builder, but I get "Field Name field is required." when I click a red X to delete a checkbox option. So it's not possible to delete a checkbox option.

This looks to be a form_builder bug I got when I clicked the fieldset button:

  Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /var/www/drupal_fresh/includes/common.inc).
    Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /var/www/drupal_fresh/includes/common.inc).
    Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /var/www/drupal_fresh/includes/common.inc).
    Warning: Invalid argument supplied for foreach() in element_children() (line 6370 of /var/www/drupal_fresh/includes/common.inc).
    Notice: Undefined index: #prefix in form_builder_field_field_widget_form() (line 153 of /var/www/drupal_fresh/sites/all/modules/form_builder_field/form_builder_field.module).

In any case, there are some problems in the UI that are blockers at least as long as the module depends on form_builder. At one point clicking the fieldset button seemed to clear all the inputs from the pane where you drag the inputs.

There is a broken "Edit Form" link showing at the bottom of the Create Phased Contest form.

Nice feature module, well documented and the code looks solid.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Would it be easier to use Webform and a scheduler module to handle this use case? Webform allows you to build a form easily, and stores the submissions, and can track # of entries / user. If you could describe the differences that would help let a user know why they would use your module instead.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Thanks for the additional info, that does seem reasonable.

Thanks for your contribution, PieIsGood!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.