[D7] Scald Flickr

Removing review bonus tag, no reviews of other projects given in the issue summary. Please read #1410826: [META] Review bonus again.

Sounds impossible, but even http://ventral.org/ didn't find anything (and we all know it's triggered by a lot of harmless stuff) =)
Well, nothing to say - great module.
There are plenty of modules using Flicr, but the provider for Scald is really original and useful one.
I couldn't locate any flows, although I've really tried to.
The only thing I wish to have - a link demo website so people can enjoy it without suffering GIT =)
Thanks

Hi Pierre,

The module looks great, but I found some minor issues:

• I also noticed you sometimes align array values:
  

  'title' => array(
    '#type'   => 'item',
    '#markup' => $image->title,
  ),

  e.g. scald_flickr.pages.inc line 70-87 and line 170-180. This might also occur on other lines/files.

• Your project (sandbox) page could be clearer. E.g. the following sentence is hard to read/understand.
  

  Search on flickr : When you create an image atom, you will have a source : Image hosted on flickr, and after you have a link : Search on flickr

• The same goes for the README.txt. Also try to choose a style/structure for your readme file. This will improve readability.

Greetings!

Some small points that are nice to change (no need of @descripton tag in the long function description, sometimes comments are broken at much less than 80 characters), but in general it looks good.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/scald_flickr.module
  --------------------------------------------------------------------------------
  FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
  --------------------------------------------------------------------------------
   7 | ERROR | All constants defined by a module must be prefixed with the
     |       | module's name, expected "SCALD_FLICKR_FLICKR_PHOTOS" but found
     |       | "FLICKR_PHOTOS"
   8 | ERROR | All constants defined by a module must be prefixed with the
     |       | module's name, expected "SCALD_FLICKR_FLICKR_API_REST" but found
     |       | "FLICKR_API_REST"
   9 | ERROR | All constants defined by a module must be prefixed with the
     |       | module's name, expected "SCALD_FLICKR_FLICKR_PHOTO_SOURCE" but
     |       | found "FLICKR_PHOTO_SOURCE"
  --------------------------------------------------------------------------------
  
  Time: 0 seconds, Memory: 11.50Mb
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. "variable_get('scald_flickr_api_key', '');": all variables defined by a module must be removed in hook_uninstall().
2. scald_flickr_feed(): the check_plain() here is wrong, because no user provided text is invloved? Make sure to read http://drupal.org/node/28984 again. Don't change your code when coder review reports false positives.

Although you should definitively fix those issues they are not absolute application blockers, so ...

Thanks for your contribution, pierre_cotiniere!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.