Hello,

I wrote a sandbox project Workbench Notify which implements sending automatically notifications to section's editors specified in Workbench Access, on a transition state set in Workbench Moderation.

Differences with Workbench Email

  • Workbench Email presents to the content creators a list of users that they can email the content updated. But if you use Workbench Access to assign editors to some specific sections of the website, the users list presented to the content creator becomes irrelevant, because the list contains all the users whose role has been set accordingly in the email transition, but these users do not necessarily have the permissions to moderate or edit the content on the specific section where it has been posted.
  • Workbench email needs a manual action from the content creators, while workkench Notify send automatically notifications.

it would be interesting to merge features of workbench notify in workbench email, in order to have a single module that handles notifications for Workbench suite.

For example, in the UI,

if workbench Access is enabled (it doesn't make sens to notify automatically if workbench access is not used) then administrator could activate sending automatically notifications to the checked role. Then all users, defined individually (but with the role) or by their role, on the content's section, in workbench acces would be notified.

If automatically notifications are not set, then the user list presented could be filtered according to the rights on the sections defined in workbench access

What do you think about this?

CommentFileSizeAuthor
#9 Issue-1952556-support-workbench-access-and-sending-a.patch4.26 KBsylvain lecoy

Comments

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Title: support workbench access and automatically sending notifications » support workbench access and sending automatically notifications

title updated

themusician’s picture

themusician commented

This is a fantastic addition. I have been exploring how to do this with the Rules module but using Workbench Email or the sandboxed Notify module would be better.

Like flocondetoile we use Workbench Access to determine who will be able to Publish content for specific sections of the the site.

teknic’s picture

teknic commented
Assigned: Unassigned » teknic

Hey flocondetoile, this hasn't dropped off my radar. The addition of workbench access checks in this module is necessary to complete its merge into the family of workbench. I also like the addition of automatic notifications, I'm not 100% where I would place that setting etc but it seems like a easy addition that could be of use.

Thanks for the suggestions and stay tuned.

teknic’s picture

teknic commented
Status: Active » Fixed

Hey guys,

Pushed a new version of Workbench Email, 7.x-3.0-rc1. This branch includes both workbench access integration and auto notify options.

@flocondetoile, thanks for the workbench_notify code, you can see I used a lot of the same functionality you had laid out.

http://drupal.org/node/2005726

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented

Thanks,

I will go to test the new version and give you a feedback

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bès’s picture

bès commented

Hello, thanks for the work, this module will fill a really missing part of workbench :)
I did some test on the 7.x-3.0-rc2 https://drupal.org/node/2007676, here some feedbacks :

  • The module is not working after a clean installation because the 'automatic' field is not in the schema (only added via hook_update_N)
  • I think the dependency to chosen should be remove, and just suggest his usage to improve UI (especially since we could avoid use it with full automatic options and that chosen is not really working now, and because it's just UI)
  • The current implementation of the hook_mail_alter break all drupal mail sending by settings 'send' to FALSE. It misses a test on the message ID.
  • I'm not sure of the last one but I think that your usage of the cron queue is not good, all example that I saw use it inside hook_cron.

I couldn't give a patch now, but will try to do it later.

bès’s picture

bès commented
Category: feature » bug
Status: Closed (fixed) » Needs work
sylvain lecoy’s picture

sylvain lecoy commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new Issue-1952556-support-workbench-access-and-sending-a.patch4.26 KB

Here is a patch from the 7.x-2.2 tag.

It basically do the following when 'workbench_access' module exist:
- Adds an ajax callback on the 'workbench_access' selector (works for multiple sections, too) which refresh the list of user to send an email to.
- Build a 'children to parent' array of section given a workbench section.
- Filters the list of user to return according to this array so only the user affected to a section or a parent section of the content being edited will appear in the list of potential users to notify.

Jonshock’s picture

Jonshock commented

@Sylvain Lecoy

When attempting to use the patch you submitted, the memory buffer is exhausted. Appears to be an infinite loop.

teknic’s picture

teknic commented
Status: Needs review » Fixed

The newest version of the module is out and supports above functionality request.

teknic’s picture

teknic commented
Status: Fixed » Closed (fixed)