Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Apr 2013 at 15:03 UTC
Updated:
4 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaThat's an interesting idea, thanks for the code. I know Nodewords (D6) had separate permissions for each meta tag, while not every meta tag needs it, it might be worth including as a submodule with a disclaimer that "this will make your Permissions page even more crazy."
Comment #2
thesame- commentedHa ha! :D I like your idea of disclaimer!
Comment #3
damienmckennaHow about this alternative approach? It provides a hidden variable, metatag_extended_permissions, which can be set to TRUE to turn on the Extended Permissions option. When this is enabled every single meta tag will have its own permission, users will have to have the 'edit meta tags' permission to see the fieldset and then their access to individual meta tags can be assigned. Food for thought, and I haven't tested it fully yet.
Comment #4
thesame- commentedThis seams to be a great idea. And code looks cleaner as well. Good job. :)
Comment #5
thesame- commentedI realized my sub-module didn't work for taxonomy terms. I gave a shot to your patch.
Got Notice: Undefined variable: metatag_name in metatag_metatags_form() (line 901 of /sites/all/modules/metatag/metatag.module).
I also noticed empty meta tag groups are not removed and nether is Meta tags tab, if user doesn't have permission to edit any of meta tags.
Patch in attachment.
Comment #7
thesame- commented#5: remove_empty_goups.patch queued for re-testing.
Comment #8
thesame- commentedI have no idea how to edit patch for re-testing. I'll just upload it again.
Comment #10
thesame- commentedOk something went seriously wrong. This patch should be fine. I hope...
Comment #11
damienmckennaComment #12
damienmckennaThis merges together the changes from #10 with the README.txt changes from #3.
Comment #13
damienmckennaSome small improvements to the README.txt file.
Comment #14
damienmckennaTag.
Comment #15
damienmckennaI've tested this and it works as intended. Thanks for the help, thesame!
Comment #16
thesame- commentedGlad to be helpful! ;]
Comment #17.0
(not verified) commentedtypo