Twitter #hashtag converter returns wrong address [#1982884]

Module Twitter (not Twitter Action, sorry for the mistake) on Drupal 7.22

Once the filter Twitter #hashtag converter is selected into

Configuration -> Text formats -> _SELECT_YOUR_FORMAT_ -> Enable filters -> Twitter #hashtag converter

Writing an Hashtag into a field, it is converted into a link to Twitter as described here
"Converts Twitter-style #hashtags into links to hashtags.org."

But the converted hashtag has wrong address, which leads always to a non existing page on Twitter.

For instance;: if I write the hashtag: #Tomorrow, the converted link is:

https://search.twitter.com/search?q=%23Tomorrow

which leads to "Sorry, that page doesn’t exist! Thanks for noticing—we're going to fix it up and have things back to normal soon."

The correct address should be:
https://twitter.com/search?q=%23Tomorrow&src=hash

Comment	File	Size	Author
#11	twitter-change_seach_url-1982884-11.patch	1.23 KB	estoyausente
#10	twitter-hashtag_returns_wrong_address-1982884-10.patch	1.37 KB	thomas.fleming
#9	1982884_9.patch	1.13 KB	royal121
#8	1982884_8.patch	1.13 KB	royal121
#7	twitter_hashtag-links_1982884_7.patch	1.23 KB	jamix
#3	search_url-1982884-3.patch	2.14 KB	plopesc

Comments

Comment #1

HyperD commented 29 April 2013 at 23:18

To make it works, I made these modifications:

Twitter.module
<9	define ('TWITTER_SEARCH',       'http://search.twitter.com');
>9	define ('TWITTER_SEARCH',       'https://twitter.com');

<243	    '!url' => '<a href="https://search.twitter.com/">search.twitter.com</a>')
>243	    '!url' => '<a href="https://twitter.com/">twitter.com</a>')

<283	    '><a href="' . $destination . '${1}">' . $prefix . '${1}</a>',
>283	    '><a href="' . $destination . '${1}&src=hash">' . $prefix . '${1}</a>',

Pay attention: it's necessary to uninstall the module also clicking on the tab Uninstall.
After the modification, reinstall the module

Of course it's possible to change the setup in Configuration -> Twitter.
However in the manner above, the module has already the correct settings by default.

Attaching patch which tries to fix this bug, basically changes the default twitter_search url, adds a $suffix parameter to _twitter_filter_text to add the new $srcparameter and changes the filter tip dependingon the twitter_search variable.

Patch has been tested against 7.x-5.x and 7.x-6.x branches.

Regards