[D7] Mini Panel Reference

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1986148

Project 2: http://drupal.org/node/1974868

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello Dustin, here are a few notes.

1) Make a more detailed README.txt. Read here for more information.

I installed this module and it's dependencies, and it works pretty much as I would expect given my prior experiences with Fields, Panels and Mini Panels.

Hi, Dustin Bons

hook_field_schema() MUST be defined in .install for it to be detected during installation and upgrade.

Hello Dustin,

* mini_panel_reference.module
- (Line 49) Apart my mistake this line is not used much. The variable $settings is not used, you can delete it.

* mini_panel_reference.info

- It is not necessary to specify that your module depends on "Filed Module", i assume this module will always be there because it is from the Drupal core more over is required (Line 11 of field.info). Delete line 5 of mini_panel_reference.info

- You should add Panels in your mini_panel_reference.info file because panels_mini is a sub module of Panels module. If you are using drush you would quickly make you realize that, your module seems impossible to activate. So add this line in your info file :
dependencies[] = panels

- You have evoked a module called "options" in your dependence (Line 6 of mini_panel_reference.info), after my research I can not find the module with that machine name. Can you tell us more about this dependence.

* Ventral pareview has found some issues with your code
http://ventral.org/pareview/httpgitdrupalorgsandboxdustin1986092git

Hi Dustin,

I've done a manual review of your module. I found the module easy to setup and use, and worked as expected. I have a few small coding style suggestions:

1) Remove pointless space on line 26.

/**
 * Implements hook_field_is_empty().
 */
function mini_panel_reference_field_is_empty($item, $field) {

  return empty($item['name']);
}

2) $ret is not very standard for declaring formatters. It might be better to just use a return array() here as per the hook definition for hook_field_formatter_info().

/**
 * Implements hook_field_formatter_info().
 */
function mini_panel_reference_field_formatter_info() {
  $ret = array(

3) There is an extra line on line 43.

I don't actually see any other issues, so I think this should be RTBC and see what the powers that be think.

Norman

Project page

Please take a moment to make your project page follow tips for a great project page.

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Implementing a hook_help(), adding options or admin configuration, or other simple hooks can help you get around this limitation.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Hi,
I went through your module and found the following issues :

.module file
> line 16
Please provide 'access arguments' if you do not wish to expose the autocomplete menu to everyone, that is, this menu is exposed right now and can be compromised with any information that you do not wish to provide to outsiders.

> line 79
Do not use '+' to merge 2 arrays, rather use PHP's array_merge() or drupal's own drupal_array_merge_deep() methods.

I'll look at this now in the Project applications sprint.

----
Top Shelf Modules - Crafted, Curated, Contributed.

This looks great, thanks for those additions!

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month and no further problems, so...

Thanks for your contribution, Dustin Bons!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.