Problem/Motivation

Code isn't using PHP's default argument values... am I missing something?

Proposed resolution

Let use PHP's default argument values.

Remaining tasks

Review patch.

Files: 
CommentFileSizeAuthor
#9 metatag-n2001178-9.patch705 bytesDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new710 bytes
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Patch attached!

Status:Needs review» Closed (works as designed)

The reason for this is to cover for when the language string is passed in as an empty string, Metatag doesn't like that so changes it to LANGUAGE_NONE.

This seems like a case where we should be validating the language in all cases, not just if an empty string is passed in. What happens if someone passes in a language that doesn't exist or is not enabled in Drupal?

Title:Default argument valuesVerify languages exist
Status:Closed (works as designed)» Active

You have a reasonable point, we'll see what we can do about improving the language validation.

Status:Active» Needs review
StatusFileSize
new662 bytes
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

What do you think of this?

StatusFileSize
new1.15 KB
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Rerolled.

StatusFileSize
new668 bytes
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

I accidentally included code from another patch in #6.

Issue summary:View changes
StatusFileSize
new709 bytes
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Rerolled.

StatusFileSize
new705 bytes
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Oops, the formatting was off.

Status:Needs review» Fixed

Committed. Thanks.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.