Problem/Motivation

Code isn't using PHP's default argument values... am I missing something?

Proposed resolution

Let use PHP's default argument values.

Remaining tasks

Review patch.

CommentFileSizeAuthor
#9 metatag-n2001178-9.patch705 bytesdamienmckenna
#8 metatag-n2001178-8.patch709 bytesdamienmckenna
#7 metatag-n2001178-7.patch668 bytesdamienmckenna
#6 metatag-n2001178-6.patch1.15 KBdamienmckenna
#5 metatag-n2001178-5.patch662 bytesdamienmckenna
#1 metatag_default-argument-values-2001178-1.patch710 bytesjantoine

Comments

jantoine’s picture

jantoine commented
Status: Active » Needs review
StatusFileSize
new metatag_default-argument-values-2001178-1.patch710 bytes

Patch attached!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Closed (works as designed)

The reason for this is to cover for when the language string is passed in as an empty string, Metatag doesn't like that so changes it to LANGUAGE_NONE.

jantoine’s picture

jantoine commented

This seems like a case where we should be validating the language in all cases, not just if an empty string is passed in. What happens if someone passes in a language that doesn't exist or is not enabled in Drupal?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Default argument values » Verify languages exist
Status: Closed (works as designed) » Active

You have a reasonable point, we'll see what we can do about improving the language validation.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2001178-5.patch662 bytes

What do you think of this?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2001178-6.patch1.15 KB

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2001178-7.patch668 bytes

I accidentally included code from another patch in #6.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
StatusFileSize
new metatag-n2001178-8.patch709 bytes

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2001178-9.patch705 bytes

Oops, the formatting was off.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.