Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#11 | interdiff-2002482-10.txt | 840 bytes | chrisjlee |
#11 | 2002482-ensure_path-11.patch | 2.74 KB | chrisjlee |
#9 | 2002482-ensure_path-9.patch | 2.22 KB | chrisjlee |
#9 | rerolled-9--2002482-ensure_path-6.patch | 1.55 KB | chrisjlee |
#9 | interdiff-2002482-9.txt | 1.33 KB | chrisjlee |
Comments
Comment #1
brennanmh CreditAttribution: brennanmh commentedChanged ensure_path to ensurePath in Sql.php
Comment #3
connorwk CreditAttribution: connorwk commented#1: ensure_path-2002482.patch queued for re-testing.
Comment #5
oenie CreditAttribution: oenie commentedAdd protected access modifier in front of the function to adher to the new OOP standards.
Comment #6
shixish CreditAttribution: shixish commentedI added the protected keyword.
Updated patch, and interdiff attached.
Comment #7
oenie CreditAttribution: oenie commentedLooks good to me, apart from a minor comment issue:
core/modules/views/lib/Drupal/views/ManyToOneHelper.php, Line 89:
// ensure_path logic. Perhaps it should be.
So i suggest RTBC when the test returns ok.
Comment #8
aspilicious CreditAttribution: aspilicious commentedLets fix the comment.
Comment #9
chrisjlee CreditAttribution: chrisjlee commentedAttempted to reroll and caused a nasty merge conflict that undid lots other api changes (add_table() -> addTable()). Instead i just manually recreated the patch since it's a couple changes. Interdiff will show changes i made from the manually rerolled.
Also, added that comment fix as per request by aspilicious in #8.
Finally, also fixed the typo in the method name. Also, there's a typo here. "ensurePpath" -> "ensurePath".
Comment #10
chrisjlee CreditAttribution: chrisjlee commentedWhoops forgot to update tags / status
Comment #11
chrisjlee CreditAttribution: chrisjlee commentedMissed one more ensure_path. This should turn green. the other should turn red.
Comment #12
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #13
alexpottCommitted 17c06e0 and pushed to 8.x. Thanks!