Rename Views method ensure_path() to ensurePath()

Changed ensure_path to ensurePath in Sql.php

#1: ensure_path-2002482.patch queued for re-testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -587,7 +587,7 @@ function ensure_table($table, $relationship = NULL, JoinPluginBase $join = NULL)
+  function ensurePath($table, $relationship = NULL, $join = NULL, $traced = array(), $add = array()) {

Add protected access modifier in front of the function to adher to the new OOP standards.

I added the protected keyword.

Updated patch, and interdiff attached.

Looks good to me, apart from a minor comment issue:

core/modules/views/lib/Drupal/views/ManyToOneHelper.php, Line 89:
// ensure_path logic. Perhaps it should be.

So i suggest RTBC when the test returns ok.

Lets fix the comment.

Attempted to reroll and caused a nasty merge conflict that undid lots other api changes (add_table() -> addTable()). Instead i just manually recreated the patch since it's a couple changes. Interdiff will show changes i made from the manually rerolled.

Also, added that comment fix as per request by aspilicious in #8.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -632,7 +632,7 @@ function ensure_path($table, $relationship = NULL, $join = NULL, $traced = array
     $traced[$join->leftTable] = TRUE;
-    return $this->ensure_path($join->leftTable, $relationship, $left_join, $traced, $add);
+    return $this->ensurePpath($join->leftTable, $relationship, $left_join, $traced, $add);

Finally, also fixed the typo in the method name. Also, there's a typo here. "ensurePpath" -> "ensurePath".

Whoops forgot to update tags / status

Missed one more ensure_path. This should turn green. the other should turn red.

Looks good to me now !

Committed 17c06e0 and pushed to 8.x. Thanks!