Overlay forms broken in IE10 for Windows 7

What is your javascript console saying?

ok, it's because of domready. See #1974580-29: Introduce domReady to remove jQuery dependency from drupal.js and clean it up.

The patch updates domready with this pull request https://github.com/ded/domready/pull/17.

Also it's a JS bug so tagging.

Working fine with the patch. I prefer the library to get updated first, but oh well...

Happy to see it :)

let's update the lib first and turn that into an update library X issue.

Author said the same word a year ago [ https://github.com/ded/domready/issues/14 ]. Drupalers need to submit a new patch to GITHUB or patch it directly.

Don't understand why this is postponed.

Patch from #3 does not fix the issue.

Furthermore, I had to manually navigate to "/#overlay=node/add/article".

The links without the overlay work. But only if you click the anchor tag, not if you click on the area around it.

I tested a few other overlay forms. All the forms which use this functionality are broken. So you cannot close an overlay form.

So you cannot close an overlay form

@see: https://drupal.org/node/2003854#comment-7565911

Console does not report that error.

I only get the follow error for the front page.

SEC7115: :visited and :link styles can only differ by color. Some styles were not applied to :visited. 
drupal

The save and publish button also looks broken.

Also how is "ready.min.js" added the drupal? Shouldn't we add it to a library somewhere?

The above patch applies the js file to
core/misc/domready/ready.min.js

If I look at the html is actually is pointing to
core/assets/vendor/domready/ready.min.js?v=master

Re-rolled the patch from #3 to the right folder. Looks like it works.

Changed the actual source instead of using the code supplied by #3.

It looks like the maintainer isn't to active on https://github.com/ded/domready

Adding Tag. Unit testing will not work with this change. Needs to be tested against multiple browsers.

Maintainer is active, the pull requests just don't merge properly.
For testing only IE is needed, it doesn't change anything for the other browsers.

I have created a pull request with the changes re-rolled. There are some subtle changes.

https://github.com/ded/domready/pull/21

Information on readystate for further reading. It has being discontinued in IE 11 in favour of onload().

http://msdn.microsoft.com/en-us/library/ie/ms534359(v=vs.85).aspx

the page you linked to talks about the script element. not for a page. it does not impact this script functionality.

thanks for making the pull request elachlan :) now we just need to wait for the commit.

Yep. Postponing on upstream.

Merged. Boom :)

https://github.com/ded/domready/pull/21#ref-commit-baafbee

Looks good to me and the patch is green! Good work everyone! :)

Committed/pushed to 8.x, thanks!