Replace theme() with drupal_render() in update system

So I'm having an issue with this section

@@ -388,10 +399,19 @@ function update_check_requirements($skip_warnings = FALSE) {
   if ($severity == REQUIREMENT_ERROR || ($severity == REQUIREMENT_WARNING && !$skip_warnings)) {
     update_task_list('requirements');
     drupal_set_title('Requirements problem');
-    $status_report = theme('status_report', array('requirements' => $requirements));
+    $status = array(
+      '#theme' => 'status_report',
+      '#requirements' => $requirements,
+    );
+
+    $status_report = drupal_render($status);

This is the part where the test is failing. If I leave the $status as using the theme() function instead of building the array for the render, all the tests pass. Any idea why?

this code part looks good

@tsphethean I've worked further on this trying to figure out why i'm not able to switch the theme function as mentioned in #3 but no luck. All tests pass if you undo the changes to that status_report theme.

Hope you have better luck, and please if you figure it out do let me know what I missed.

#3: 2009688-replace_theme_with_drupal_render_in_update-3.patch queued for re-testing.

I'm getting the same SimpleTest errors in the Update Functionality tests regardless of whether I have this patch applied or not so want to see what testbot thinks, just in case its something in my setup.

Tests were failing because it looks like the structure of $requirements has changed, hopefully this should do it.

Ok, tests were failing for other instances of theme('status_report') so have updated them too, and then tweaked theme_status_report() to accept the new variables passed in from drupal_render().

Just did a quick test, and if I update the theme function without doing the drupal_render conversion then it will fail... so should the new issue also do the conversions for all places that theme is used?

@thedavidmeister - no problem, thanks for the help.

Opened #2030805: Make theme_status_report compatible with drupal_render() and added it to #2015147: [meta] Improve the DX of drupal_render(), renderable arrays and the Render API in general

Need to resolve #2030805: Make theme_status_report compatible with drupal_render() first.

#2030805: Make theme_status_report compatible with drupal_render() has been resolved.

#2030805: Make theme_status_report compatible with drupal_render() is partially resolved. Also, another approach is up for discussion in #2041283: theme_status_report() is severely broken.

Re-activating since #2041283: theme_status_report() is severely broken was committed. I haven't read through this thoroughly but I'm guessing the patch will need updating.

Ok, so #2041283: theme_status_report() is severely broken has gone in, which means this can go back to pretty much the same patch as #3 and should now pass (seems good locally).

This still leaves us with theme('status_report') to be converted in install.core.inc and SystemInfoController::status() - but I think they are covered by other issues.

One small coding style nitpick: two arrays are missing commas after the last item

Missing commas added - thanks @pplantinga

Committed 36d5732 and pushed to 8.x. Thanks!

Changing title so that it's not confused with the update module in Drupal core. The patches in this issue touch the update system, not the update (manager) module.

Created an issue for the update module: #2048933: Replace theme() with drupal_render() in update module.