media_browser_plus_taxonomy_term_presave() alters the parent for the media_root folder to itself causing endless loops and crashing. Patch does a check to allow for a parent of = 0

CommentFileSizeAuthor
#2 media_browser_plus-media-root-term-parent-handling-2013373-2.patch575 bytesdas-peter
#1 media_browser_plus.term_root.save_.patch795 bytessherakama
media_browser_plus.term_root.save_.patch760 bytessherakama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sherakama’s picture

sherakama CreditAttribution: sherakama commented
FileSize
media_browser_plus.term_root.save_.patch795 bytes

Small re-roll of original patch.

das-peter’s picture

das-peter CreditAttribution: das-peter commented
Status: Needs review » Needs work
Issue tags: +Needs tests
FileSize
media_browser_plus-media-root-term-parent-handling-2013373-2.patch575 bytes

That doesn't sound good but I don't think the attached patches are the best way to handle this issue.
@sherakama Could you give the attached patch? (isset() should return true for all values (including 0) except NULL)
How about testing it right away with a test-case? It would be good to have test-coverage for this as the issues priority says "major" ;)

rkcreation’s picture

rkcreation CreditAttribution: rkcreation commented

#2 fix the bug for me, just !isset instead of empty !

das-peter’s picture

das-peter CreditAttribution: das-peter commented

Fix pushed: http://drupalcode.org/project/media_browser_plus.git/commit/e57b62f
Still needs tests though.