Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
media_browser_plus_taxonomy_term_presave() alters the parent for the media_root folder to itself causing endless loops and crashing. Patch does a check to allow for a parent of = 0
Comment | File | Size | Author |
---|---|---|---|
#2 | media_browser_plus-media-root-term-parent-handling-2013373-2.patch | 575 bytes | das-peter |
#1 | media_browser_plus.term_root.save_.patch | 795 bytes | sherakama |
media_browser_plus.term_root.save_.patch | 760 bytes | sherakama | |
Comments
Comment #1
sherakama CreditAttribution: sherakama commentedSmall re-roll of original patch.
Comment #2
das-peter CreditAttribution: das-peter commentedThat doesn't sound good but I don't think the attached patches are the best way to handle this issue.
@sherakama Could you give the attached patch? (
isset()
should return true for all values (including 0) exceptNULL
)How about testing it right away with a test-case? It would be good to have test-coverage for this as the issues priority says "major" ;)
Comment #3
rkcreation CreditAttribution: rkcreation commented#2 fix the bug for me, just
!isset
instead ofempty
!Comment #4
das-peter CreditAttribution: das-peter commentedFix pushed: http://drupalcode.org/project/media_browser_plus.git/commit/e57b62f
Still needs tests though.