[D7] Total Gallery Formatter

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxjidrone2015429git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, in total_gallery_formatter.module file:
lines 100-103, 138-141, 150-151, 175-183, 185 use the t() function

I'm not positive that this module is different enough from Gallery Formatter to merit a new module. The main advantage is that it has more options. It might be worth checking to see if those options could be added to the existing Gallery Formatter instead...

Just in case the powers-that-be do think this module is unique enough to merit it's own module, I've got a few comments as well.

• Several times in the README file and in the description, the module refers to itself as "Total Gallery Fotmatter"
• By default, this plugin uses a stretched version of the images (400x400). Perhaps it could mimic Gallery Formatter and create its own image format for default.
• The js does not meet Drupal coding standards: https://drupal.org/node/172169.
• The automatic scroll seemed a bit fast to me, perhaps an option to change the time between slides could be added?
• There's no way to scroll slides other than clicking the image in the pager below the main image. Perhaps there could be the option to navigate between slides in other ways?
• Use yes/no instead of 1/0 for options on manage display page.

I know some of these are a little nitpicky, so feel free to argue with me if you disagree.

Change status to "needs work"

Okay, you've convinced me. I'll vote for you when you've fixed the issues :)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

• You have a typo on your project page, "Fotmatter".
• Instead of a file_exists() check in the field settings form, use hook_requirements() in a .install file to make sure the js library is installed properly. I'm assuming it's actually required.
• The options for $element['slides_options']['scroll_fx'] should also be run through t().

Otherwise this looks nice, thanks for addressing the duplication issue. None of the above are blocking issues. I'm unassigning this issue so reviewers know it's open for anyone.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

Review of the 7.x-1.x branch:

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /home/klausi/pareview_temp/total_gallery_formatter.install
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   18 | WARNING | Do not use check_plain() on string literals, because they
      |         | cannot contain user provided text
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• Please add the differences to existing modules to your project page, so that users can make an educated decision which module to use.

But otherwise looks good to me, so ...

Thanks for your contribution, jidrone!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

I am giving credits to the users who participated in this issue.