Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Jun 2013 at 10:02 UTC
Updated:
30 Aug 2013 at 22:24 UTC
This module allows site admin to add image/text popup banner.
Banner is shown to user once in specified time interval.
Link to my project page: https://drupal.org/sandbox/LoyC/2022991
git clone http://git.drupal.org/sandbox/LoyC/2022991.git popup_banner
Reviews of other projects:
https://drupal.org/node/2023661#comment-7561025
https://drupal.org/node/2022569#comment-7561065
https://drupal.org/node/2024431#comment-7564031
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxLoyC2022991git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
LoyC commentedFixed everything
Comment #3
ronfeathers commented- Please provide a menu link in .module file to the configuration page by putting the url in yout .info file:
configure = admin/config/user-interface/popup_banner
I think you should unset your variables on uninstall, too.
Everything seems to work, though. Nice job so far.
~R~
Comment #4
LoyC commentedThanks for review. I have added configure link, and all variables are now deleted after uninstall.
Comment #5
LoyC commentedAdding PAReview: review bonus tag
Comment #6
klausihttps://drupal.org/project/popup
https://drupal.org/project/popup_message
This sounds like a feature that should live in the existing popup or popup_message project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the popup or popup_message issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.
If that fails for whatever reason please get back to us and set this back to "needs review".
Comment #7
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7.0
PA robot commentedAdded Reviews of other projects