Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Anonymous (not verified)
Created:
18 Jun 2013 at 17:59 UTC
Updated:
3 Jul 2017 at 17:02 UTC
Jump to comment: Most recent
Comments
Comment #1
Vasiliy Grotov commentedHello.
Please, take a look at Ventral review.
Also delete the master branch and use version named branches instead - https://drupal.org/empty-git-master.
And I can't clone your repo - please, update the link.
Thanks.
Comment #2
Vasiliy Grotov commentedComment #3
Vasiliy Grotov commentedWhoops. Missed the target. ))
Sorry about that.
Comment #4
Anonymous (not verified) commentedThanks Vasiliy! I have fixed all of the issues from Ventral review, created a named branch, and removed the master branch.
Comment #5
Anonymous (not verified) commentedComment #6
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #7
LoyC commentedInstalled on clean drupal 7.22 and it works great, even on IE7. You could add version in .info file. There are only 2 functions so not much to review.
Nice clean module :)
Comment #8
ronfeathers commentedWorks great for me, too - even with our new SkipTo module. Very nice.
Might join lines 22-23 in .module file, to keep line breaks out of t(), but otherwise looks great.
~R~
Comment #9
Anonymous (not verified) commentedThanks so much for the feedback LoyC and ronfeathres! I have removed the line break between lines 22 and 23. As for for the version parameter in the .info file, unless I missed something I think this should get added by Drupal's package script once the module has full project access. Do you know if this is correct?
Comment #9.0
Anonymous (not verified) commentedAdding links to reviews.
Comment #10
Anonymous (not verified) commentedJust finished doing 3 reviews, so adding the PAReview: review bonus tag.
Comment #11
klausimanual review:
But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Assigning to cweagans as he might have time to take a final look at this.
Comment #12
Anonymous (not verified) commentedThanks so much for the feedback klausi! I have removed the scroll_to_destination_anchors_init() function and implemented the JavaScript using the .info scripts[] directive instead.
That would be great if you could manually promote the project to a full project since this module will probably not meet the code requirements for me to be a vetted git user yet.
Comment #13
klausino objections for more than a week, so ...
Thanks for your contribution, keeganhr!
I promoted this project for you: https://drupal.org/project/scroll_to_destination_anchors
Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #14
Anonymous (not verified) commentedThank you so much klausi, I will do that!
Comment #15.0
(not verified) commentedFixing git clone link.