This module modifies the default behavior of destination anchor links such as <a href="#block-system-main">Main content</a> so that users will be smoothly scrolled to the destination instead of immediately being jumped.

Project

https://drupal.org/sandbox/keeganhr/2022427

Repository

git clone http://git.drupal.org/sandbox/keeganhr/2022427.git scroll_to_destination_anchors

Reviews of other projects

https://drupal.org/node/2013591#comment-7562953
https://drupal.org/node/1986548#comment-7563047
https://drupal.org/node/2020219#comment-7563087

Comments

Vasiliy Grotov’s picture

Status: Needs review » Needs work

Hello.

Please, take a look at Ventral review.

Also delete the master branch and use version named branches instead - https://drupal.org/empty-git-master.

And I can't clone your repo - please, update the link.

Thanks.

Vasiliy Grotov’s picture

Issue tags: +PAreview: review bonus
Vasiliy Grotov’s picture

Issue tags: -PAreview: review bonus

Whoops. Missed the target. ))
Sorry about that.

Anonymous’s picture

Thanks Vasiliy! I have fixed all of the issues from Ventral review, created a named branch, and removed the master branch.

Anonymous’s picture

Status: Needs work » Needs review
PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

LoyC’s picture

Installed on clean drupal 7.22 and it works great, even on IE7. You could add version in .info file. There are only 2 functions so not much to review.
Nice clean module :)

ronfeathers’s picture

Works great for me, too - even with our new SkipTo module. Very nice.
Might join lines 22-23 in .module file, to keep line breaks out of t(), but otherwise looks great.
~R~

Anonymous’s picture

Thanks so much for the feedback LoyC and ronfeathres! I have removed the line break between lines 22 and 23. As for for the version parameter in the .info file, unless I missed something I think this should get added by Drupal's package script once the module has full project access. Do you know if this is correct?

Anonymous’s picture

Issue summary: View changes

Adding links to reviews.

Anonymous’s picture

Issue tags: +PAreview: review bonus

Just finished doing 3 reviews, so adding the PAReview: review bonus tag.

klausi’s picture

Assigned: Unassigned » cweagans
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus +PAreview: single application approval

manual review:

  1. scroll_to_destination_anchors_init(): why do you need that function? If you want your Javscript on every page then use the scripts[] directive in the info file. See https://drupal.org/node/542202
  2. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to cweagans as he might have time to take a final look at this.

Anonymous’s picture

Thanks so much for the feedback klausi! I have removed the scroll_to_destination_anchors_init() function and implemented the JavaScript using the .info scripts[] directive instead.

That would be great if you could manually promote the project to a full project since this module will probably not meet the code requirements for me to be a vetted git user yet.

klausi’s picture

Status: Reviewed & tested by the community » Fixed

no objections for more than a week, so ...

Thanks for your contribution, keeganhr!

I promoted this project for you: https://drupal.org/project/scroll_to_destination_anchors

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Anonymous’s picture

Thank you so much klausi, I will do that!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Fixing git clone link.