I have something weird going on with my the [current-page:title] | [site:name] pattern for the global Page title metatag. I debugged it for a while, but couldn't find the real cause.

It made me dig into the metatag generation process, though, and I started to wonder what would happen if the pattern were blanked out. My expectation is that metatag will not add anything if the pattern is blank but in fact it adds an empty title tag.

Comments

greggles’s picture

Status: Active » Needs review
StatusFileSize
new547 bytes
damienmckenna’s picture

Status: Needs review » Fixed
StatusFileSize
new1005 bytes

It might not be best to use !empty($data->value) because the empty() construct will consider zeros as either integers, floats or strings to be FALSE though it may be a valid output string.

damienmckenna’s picture

Status: Fixed » Needs review

Wrong status.

Status: Needs review » Needs work

The last submitted patch, metatag-n2024277-2.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new614 bytes

This should work.

damienmckenna’s picture

Status: Needs review » Fixed

Committed, thanks for the suggestion, greggles!

damienmckenna’s picture

Status: Fixed » Needs work

Ok, that didn't work, it completely breaks all output.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new630 bytes

This should work better.

damienmckenna’s picture

Status: Needs review » Fixed

Committed, now back to normal again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.