Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jun 2013 at 14:26 UTC
Updated:
28 Jul 2013 at 04:51 UTC
Jump to comment: Most recent file
I have something weird going on with my the [current-page:title] | [site:name] pattern for the global Page title metatag. I debugged it for a while, but couldn't find the real cause.
It made me dig into the metatag generation process, though, and I started to wonder what would happen if the pattern were blanked out. My expectation is that metatag will not add anything if the pattern is blank but in fact it adds an empty title tag.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | metatag-n2024277-8.patch | 630 bytes | damienmckenna |
| #5 | metatag-n2024277-5.patch | 614 bytes | damienmckenna |
| #2 | metatag-n2024277-2.patch | 1005 bytes | damienmckenna |
| #1 | 2024277_no_tag_if_pattern_is_blank.patch | 547 bytes | greggles |
Comments
Comment #1
gregglesComment #2
damienmckennaIt might not be best to use !empty($data->value) because the empty() construct will consider zeros as either integers, floats or strings to be FALSE though it may be a valid output string.
Comment #3
damienmckennaWrong status.
Comment #5
damienmckennaThis should work.
Comment #6
damienmckennaCommitted, thanks for the suggestion, greggles!
Comment #7
damienmckennaOk, that didn't work, it completely breaks all output.
Comment #8
damienmckennaThis should work better.
Comment #9
damienmckennaCommitted, now back to normal again.