The patch at #1903746-44: Replace the views grid table template with one using divs makes the new views grid look a little janky in Bartik. We need to add some styling cleanup and responsive support for views-grids so they look/work properly.

Comments

Status:Active» Needs review
StatusFileSize
new2.93 KB
PASSED: [[SimpleTest]]: [MySQL] 56,396 pass(es).
[ View ]

Patch

StatusFileSize
new424.89 KB
new397.3 KB

Horizontal:

horizontal-grid.png

Vertical:

vertical-grid.png

Issue tags:+VDC

Just in general they are looking great!

StatusFileSize
new2.64 KB
PASSED: [[SimpleTest]]: [MySQL] 56,764 pass(es).
[ View ]

Removed the first/last class selectors since they're no longer provided by the plugin

Status:Needs review» Needs work
Issue tags:-Needs manual testing

Looks good, just a couple CSS nitpiks and I say ship it:)

+++ b/core/themes/bartik/css/style.css
@@ -1929,6 +1929,111 @@ div.admin-panel .description {
+  border-bottom: 0 none;
...
+  border-bottom: 0 none;
...
+  border-right: 0 none;
...
+    border: 0 none;

0 alone will suffice.

Status:Needs work» Needs review
StatusFileSize
new1 KB
new2.62 KB
PASSED: [[SimpleTest]]: [MySQL] 59,917 pass(es).
[ View ]

Fixed very minor nitpick in #7.

Status:Needs review» Reviewed & tested by the community

This looks good to me and is fairly small bit of CSS to boot.

RTBC+1.

Assigned:Mark Carver» JohnAlbin

Assigning to John Albin for a css review...

Status:Reviewed & tested by the community» Needs review

I think alexpott meant to move this down to "needs review."

I don't know that John Albin Himself™ needs to review this, but what we need is something a bit more firm like "I inspected the patch line by line, can confirm the approach taken here is the best one, checked it against the CSS/markup standards, and tested it in X browsers, and it looks good to me."

Issue summary:View changes
Status:Needs review» Reviewed & tested by the community
StatusFileSize
new114.57 KB

I have applied the patch #8 its working fine for my machine .

Status:Reviewed & tested by the community» Needs review

@brahmjeet789: please see what Angie said back in #12 would qualify to set this issue to RTBC.

Issue tags:+CSS

Status:Needs review» Needs work
  1. +++ b/core/themes/bartik/css/style.css
    @@ -1929,6 +1929,111 @@ div.admin-panel .description {
    +@media all and (max-width: 520px) {
    +  .views-view-grid .views-col {
    +    float: none;
    +    padding: 0;
    +    width: 100% !important;
    +  }

    Is there a good reason not to use mobile first media queries here?

  2. +++ b/core/themes/bartik/css/style.css
    @@ -1929,6 +1929,111 @@ div.admin-panel .description {
    +.views-view-grid.vertical .views-row {
    +  margin-top: 30px;
    +  margin-bottom: 30px;
    +}
    +
    +.views-view-grid.vertical .views-row:first-child {
    +  margin-top: 0;
    +}
    +
    +.views-view-grid.vertical .views-row:last-child {
    +  margin-bottom: 0;
    +}

    I can see few situations where we're adding styling just to undo it for first/last children.

    Can I suggest the adjacent sibling selector instead? It would reduce the code required a lot.