[D7] Scald Webform

Hi mavin,

This is the ventral review with minor issues

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 16 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/scald_webform.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 104 | ERROR | Missing parameter type at position 1
--------------------------------------------------------------------------------

Be sure you follow the standard code

After you reviewed 3 projects I think you can move your issue to high priority.

You have a bad link in your issue on the sandbox link, it's : https://drupal.org/sandbox/mavin/2033717

Btw, you can also complete your project page, with more info about your module.

Because the form, which contains form token, cannot be cached, you will need this:
$atom->rendered->nocache = TRUE;

Hi,

after some testing :
- if we have no webform we can validate and create an atom
- it is preferable to use preprocess function rather than putting the code in the template file

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.