[D7] SN FB Dynamic Cover Photo

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2035493

Project 2: https://drupal.org/node/2034513

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxsn_idea_engineers2034...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Some of the code review comments:

sn_fb_dynamic_cover_photo.install:
• Line #44, 51 and 58: Field descriptions should be different

sn_fb_dynamic_cover_photo.module:
• Line #12 and 13: As per developer API, image dimensions should be 851px by 315px but MACROs that we used defined width as 850px and height as 316px.
• Lie # 100: Can we have a wrapper function for all curl requests
• Line # 292: We should have an error scenario handling in case json /result is not proper i.e. json_decode fails
• Line # 157: Unused variable
• Line # 236: Where are we using variable $dir_images_type
• Line # 268: Unused variable $album_name

sn_fb_dynamic_cover_photo.admin.inc:
• Line # 14: Unused variable
• Line # 83: Don’t share app id and secret as default value
• Line # 50: Instead of using text-field with readonly attribute, try to use markup. Readonly attribute can be a security issue
• Line #96: is it possible to show only those content type which have image field associated with them

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2035493

Project 2: https://drupal.org/node/2034513

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.