This module implements dynamical update of views by nodejs after executing rules
action.
This module implements rules action which we can add to any rule for updating
some views (views which need update, one can select in action).
During updating of views all arguments that are already passed to view will be
taken into account.
It is also correctly working with views which use ajax.

Module Page: https://drupal.org/sandbox/AndrewsizZ/2046401

Branch: 7.x-1.x
Tag: 7.x-1.0-alpha1

Reviews of other projects:
https://drupal.org/node/2036457#comment-7665373
https://drupal.org/node/2045195#comment-7665323
https://drupal.org/node/2029575#comment-7665339

Comments

andrewsizz’s picture

andrewsizz commented
Issue tags: +PAreview: review bonus

Added reviews of other projects.

artur.martirosyan’s picture

artur.martirosyan commented

All looks good, except for misspelled word 'dynamical' across the code.

artur.martirosyan’s picture

artur.martirosyan commented
Issue summary: View changes

added reviews of other projects

andrewsizz’s picture

andrewsizz commented

@arthgwyr
Hi, fixed my typo.

andrewsizz’s picture

andrewsizz commented
Issue summary: View changes

fixed my typo

fluxsauce’s picture

fluxsauce commented
Status: Needs review » Needs work

http://ventral.org/pareview/httpgitdrupalorgsandboxandrewsizz2046401git is clean.

https://drupal.org/sandbox/AndrewsizZ/2046401

  • Does not describe the use case, IE why would someone want to use this module? Why use node.js, and why is that important?
  • Uses dynamical in description ("dynamically") and throughout code and in README.txt, despite #3 "fixed my typo"
andrewsizz’s picture

andrewsizz commented
Status: Needs work » Needs review

Hi @FluxSauce.
Thanks for your review.
You need to use this module if you want to update some views for all users who review these views after some event on the site. I use node.js for high perfomance.

I am going to fix 'dynamical' word spelling in the next commit as it doesn't have significant influence on the work of the module. But first I will make sure what variant is correct.

fluxsauce’s picture

fluxsauce commented
Status: Needs review » Needs work

Hi @AndrewsizZ, saying it's fixed or that you're going to make the change, but making no changes doesn't mean that it's resolved.

You also need to set the default branch to 7.x-1.x. See https://drupal.org/empty-git-master

That explanation needs to be clear, both in the project description and the README. Currently, there's no technical justification. Describing the server-side nature of Node.JS and how you're using it would be helpful.

Also, can you please update the description / README with some use cases or examples?

Please see https://drupal.org/node/1587704 - specifically "Documentation checks:

andrewsizz’s picture

andrewsizz commented
Status: Needs work » Needs review

Hi.
1) Branch 7.x-1.x enabled as default.
2) Link to documentation which can help to configure node.js on server is already added in README(CONFIGURATION section).
3) Added "Why do you need to use this module?" and example to description / README.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Assigned: Unassigned » kscheirer
Status: Needs review » Reviewed & tested by the community
Issue tags: -PAreview: review bonus

manual review:

  1. views_nodejs_preprocess_views_view(): this is a hook implementation and should be documented as such, see https://drupal.org/node/1354#hookimpl
  2. views_nodejs_preprocess_views_view(): $settings is undefined in some case and will throw PHP notices. Please enable PHP notices in your dev environment and fix them.

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

andrewsizz’s picture

andrewsizz commented

Hi klausi.
Thanks for your review.
1) Fixed documentation of hook_preprocess_views_view()
2) Tested with enabled PHP notices, but notices not detected, not sure in which case it may happen.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Assigned: kscheirer » Unassigned
Status: Reviewed & tested by the community » Fixed

I'm not really sure what this module does from the description. Why would a view need a special update after a node is saved? Maybe I'm not familiar enough with node.js - I see you're sending some channel information to node.js when the rules is executed, how is that useful? Does node.js need to be configured in some way to make use of that information?

Several typos: on the project page, README, and rules.inc "dynamical", in the .info file "Dinamical" - should all be "dynamically". In the module file "chennel" should be "channel".

The code looks good though, those are minor issues.

Thanks for your contribution, AndrewsizZ!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

andrewsizz’s picture

andrewsizz commented

Thank you very much, will fix all minor issues. =)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

fixed project page link