Closed (fixed)
Project:
Open Atrium
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Jul 2013 at 15:38 UTC
Updated:
3 Sep 2013 at 13:12 UTC
Things worked fine with Open Atrium before this recent update.
Now I get this error and it won't go away
Notice: Undefined variable: classes in include() (line 22 of \oa\profiles\openatrium\themes\radix\templates\navbar.tpl.php).
Notice: Undefined variable: attributes in include() (line 22 of \oa\profiles\openatrium\themes\radix\templates\navbar.tpl.php).
installing and configuring Backbone makes no difference.
Comments
Comment #1
hass commentedComment #2
dsnopekThis is definitely Open Atrium, in fact, I recognize this error. :-) It's attempting to use Navbar 1.0-alpha10 with an older version of Radix. Until Open Atrium can update it's Radix version (which depends partly on this issue: #1757466: Prefix all navbar classes to prevent theme clashes), this error will occur.
Comment #3
dsnopeknavbar 1.0-alpha10 conflicts with older Radix used by OpenAtrium ...
... but we can't update it until some fixes get into Navbar which fix conflicts between the newer versions of Navbar and Bootstrap. So, we're likely waiting on navbar 1.0-alpha11 before we can include it in OpenAtrium and update Radix.
Solution for now: don't update Navbar!
Comment #4
dsnopekNavbar 1.0-alpha10 (plus patches to allow it work with Radix) did get included in Panpoly 1.0-rc5: #1971292: Minor fixes for Navbar module in panopoly_admin.make
This should allow OpenAtrium to update it's version of Radix, but this will also require some changes to OA Radix.
But we're much closer!
Comment #5
shadcn commentedLet me know how I can help with that.
David's (@dsnopek) patch here fixes the issues with Navbar + Bootstrap themes. We tested it with the latest Radix and it works well. It made it into Panopoly RC5.
Comment #6
mpotter commentedThanks for the link. I'm hoping to have the navbar and radix stuff updated to work with the latest Panopoly rc5 early next week. But yes, right now the -dev release looks broken (breakpoint and navbar).
Comment #7
mpotter commentedShould be fixed in the oa_core commit dd96de7. Also see the update to oa_radix to bring in the latest version of the Radix theme.
The latest navbar puts the Shortcuts into a separate tray. For the OA2 toolbar I added javascript to move the shortcuts to the top of the Admin menu like we had before. We also hide the normal navbar in both javascript and in css in case people need to undo this in their own theme.
OA2 also only uses the vertical menu style for the navbar.
Comment #8
mpotter commentedHmm, still an issue with the padding-top of the body tag. Looks like navbar javascript is overriding this. Man, the navbar stuff really is intrusive and not really suited for using outside of their fancy navtray structure. Maybe more of a javascript expert could improve how OA2 is using the navbar tray. But in any case it seems bad to force override the body.padding-top like it does.
Comment #9
mpotter commentedOpened new issue for this #2064175: Body padding-top not set
Comment #10
wizian commentedI am still getting the same error messages.
On existing project and new install with updated modules from 2013-08-14, oa_core (beta2+21), oa_radix (beta1+3-dev) and radix I am still getting the errors. Perhaps I am missing something.
I have tried radix versions 2.x-beta1-37 and latest d.o. build..beta1-43 builds (with deleted cache ) but undefined variables are still being thrown up.
Be pleased to get some feedback or ideas on what I have to do to get rid of the messages.
Comment #11
carlos.macao commentedMe too.
Comment #12
mpotter commentedYou need to do a git clone of the latest -dev and run the build.sh to run drush make to get the correct versions of modules and relevant patches. I cannot reproduce this in a fresh installation, so there is still something not quite right with your install.
If you still get this problem, post a step-by-step procedure for how to reproduce it from a fresh install.
Comment #13.0
(not verified) commentedfull error message included