Closed (fixed)
Project:
Composer Manager
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Jul 2013 at 19:37 UTC
Updated:
1 Dec 2013 at 22:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerHere is a patchfile, but for sure you could also get the relative clean commit history while porting.
Comment #2
cpliakas commentedLot to take in! Thanks for the contribution and working on this.
Comment #3
nick_vhDon't we need to add an initial slash? Had issues without the initial slash when I ported my module.
Looks very complete otherwise! Testing it
Comment #4
nick_vhSome changes happened in Drupal 8 so this port did not fully work anymore (basically it crashed but foundation was good)
Attached is a patch that makes it work again and we now have a first module that depends on it : https://drupal.org/project/aws_sqs
Please commit this to a branch of 8.x-1.x so we can start using this for future Drupal 8 modules.
Also, I added an EventListener so it loads when it does a hook_init, but this seemed not to work properly because in aws_sqs I still need to call the composer_autoload function. Anyway, food for thought! :)
Comment #5
nick_vhA screenshot to show that it works ;-)
Comment #6
cpliakas commentedCommitted patch at #2054947-4: Convert composer manager to Drupal 8 as the 8.x-1.x branch.
Marking as needs work just because it probably does and will as D8 continues to evolve.
Comment #7
kostajh commented@Nick_vh what version of D8 are you working with? I've tried enabling Composer Manager on 8.0-alpha8, and on a clean install of bf3e9cfaaafa6179 (Nov 2), but whenever I try enabling I get this error message https://drupal.org/documentation/rebuild.
Comment #8
kostajh commentedNevermind, I realized that after enabling Composer Manager with Drush, I had to run
drush composer-json-rebuild.Comment #9
dmouseI add "composer_manager.local_task.yml" for create admin tabs.
I changed the class SettingsForm, the class SystemConfigFormBase not exist more.
I add submitForm in SettingsForm for save configuration
Update composer_manager.routing.yml with tag _title in settingsForm
I changed drupal_get_form to "\Drupal::formBuilder()->getForm", drupal_get_form is deprecated.
Comment #10
dmouseComment #11
dmouseIdea:
In drupal now has a composer.json file which already has dependencies, I think it should be compared with contributed modules dependencies.
BTW It would be interesting to run commands using the UI
- http://ankitchauhan22.blogspot.mx/2013/02/run-symfony-command-from-contr...
- https://github.com/composer/composer/blob/master/src/Composer/Command/Up...
Comment #12
damiankloip commentedFor sanity's sake, I would recommend creating separate follow up issues from now on against the 8.x branch. This will make a better issue trail in the commit logs too.
Comment #13
dawehner+ 100
Comment #14
kostajh commentedIs there any reason for this issue to stay open then? If so, the summary should be updated.
Comment #15
dawehnerI would say no.