Panopoly Search RC4 has a function we use in an update hook that is not present in the version of Search API we ship with RC5 (sigh). We should wrap the update function in a function_exists.

CommentFileSizeAuthor
#5 panopoly_search-update-2063715-5.patch3.98 KBdsnopek
#2 2063715-panopoly-search-update-conditional-2.patch919 bytespopulist
#1 2063715-panopoly-search-update-conditional-1.patch533 bytespopulist
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

populist’s picture

populist CreditAttribution: populist commented
Status: Active » Needs review
FileSize
2063715-panopoly-search-update-conditional-1.patch533 bytes

Here is a quick patch to do this

populist’s picture

populist CreditAttribution: populist commented
FileSize
2063715-panopoly-search-update-conditional-2.patch919 bytes

Here is a better patch that catches it in two places

thebruce’s picture

thebruce CreditAttribution: thebruce commented

Thanks @populist. We were in this position on one of our projects, RC3 -> RC5 and applied exactly this approach to get it to roll.

lsolesen’s picture

lsolesen CreditAttribution: lsolesen commented
Issue summary: View changes
Issue tags: +sprint

Added to sprint as there is a patch and people has succesfully used it.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Title: Panopoly Search UpdateDB Breaks with RC3 -> RC5 » Panopoly Search update breaks from older versions (for example, 1.0-rc3, 1.0-rc4)
Component: Code » Search
FileSize
panopoly_search-update-2063715-5.patch3.98 KB

I've been working on a updating some sites from Panopoly 1.0-beta4 on Pantheon for a client. Several changes are required to several hook_update_N() functions, not just the one in @populist's patch.

Here is a patch with the version that I've got working - it shouldn't have any affect on new sites.

  • dsnopek committed 51d07ac on 7.x-1.x 
    Update Panopoly Search for #2063715 by populist, dsnopek: Panopoly...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Needs review » Fixed

Committed! Let's see how the upgrade tests on Travis-CI go:

https://travis-ci.org/panopoly/panopoly/builds/33627534

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.