Description

Adds a webform component that lets the user enter a URL.
The module verifies that a valid URL is entered and displays the result as a link.

Requirements:

  • webform

Related projects:

Link to project page

Link to git repository

  • git clone --branch 7.x-1.x git.drupal.org:sandbox/Fengtan/2063795.git webform_link
CommentFileSizeAuthor
webform_link_screenshot.png9.32 KBfengtan

Comments

PA robot’s picture

PA robot commented
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2064141

Project 2: https://drupal.org/node/2060513

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxFengtan2063795git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Status: Needs work » Needs review

Applied coding standards.
Looks like the following won't fix though - these are not actual hooks, but instead implementations of the webform API:

./components/link.inc: all functions should be prefixed with your module/theme name to avoid name clashes.

function _webform_defaults_link() {
function _webform_edit_link($component) {
function _webform_theme_link() {
function _webform_render_link($component, $value = NULL, $filter = TRUE) {
function _webform_display_link($component, $value, $format = 'html') {
function _webform_table_link($component, $value) {
function _webform_csv_headers_link($component, $export_options) {
function _webform_csv_data_link($component, $export_options, $value) {
Sabareesh’s picture

Sabareesh commented
Status: Needs review » Needs work

Hi Fengtan,

I installed you module and tested it once. The functionality looks good to me.

Few suggestion though.,

1. In readme.txt "Copy the entire module directory the Drupal sites/all/modules directory.", please rephrase this.
2. 'Login as administrator ...' you dont have a full stop here, please add one.
3. Why is the file names as link.inc, as a standard we name that with the module's name.

The automatic review still shows some issue, please do correct it as mentioned above.

But still it was a nice project!

fengtan’s picture

fengtan
Location Montreal, Canada
commented

Thanks for the review Sabareesh.

1. Rephrased sentence in f8a5bc04

2. Added full stop in 4c817dc9

3. link.inc is named after the component's name (link) - not the module name (webform_link). This is to follow webform's conventions: for instance webform contains a component named textfield defined in textfield.inc. This .inc file contains implementations of the webform API, e.g. implementations of _webform_defaults_component():

  • Webform's textfield component is defined by _webform_defaults_textfield() in file textfield.inc
  • Similarly, my link component is defined by _webform_defaults_link() in file link.inc

Hence the warnings from PAReview. Not sure what to do with them. I think it follows webform's guidelines though :

The word "component" should be replaced with the name of the component type (such as textfield or select). These are not actual hooks, but instead samples of how Webform integrates with its own built-in components.

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Status: Needs work » Needs review
chester_martin’s picture

chester_martin commented

Hi Fengtan,

I reviewed your module. The code looks good and installation and configuration worked as aspected.

Have you considered merging you webform component code with the Link module? That is how, for exampel, the Name module is structured.

fengtan’s picture

fengtan
Location Montreal, Canada
commented

Thanks for the review chester_martin.

Merging this module with Link looks interesting, though I wonder if it is the best solution if one needs links for webforms but not for fields.

Not sure if the convenience of having a single module worths the modularity provided by 2 distinct, complementary projects.

I am leaving this module as a separate project for now but I am open to further consideration if there is further demand from the community.

chester_martin’s picture

chester_martin commented

Yes, you're right. there's probably a performance advantage keeping a modules footprint small and code to the point. Just worth mentioning. Maybe you come up with some other way to collaborate with the link module in the future.

Good luck!

oboz’s picture

oboz commented
Status: Needs review » Reviewed & tested by the community

I reviewed your module. Everything is working correctly. Errors or bottlenecks in the code were not found.

Moreover, I needed a module like this, and I'm happy. :)

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

Looks good, nice implementation.

Thanks for your contribution, Fengtan!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.