Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Aug 2013 at 16:43 UTC
Updated:
11 Jan 2014 at 17:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
paul rowell commentedHi blencorp,
Automatic review picked up a few things: http://pareview.sh/pareview/httpgitdrupalorgsandboxblencorp2064311git
Manual review
floating_buttons.module
line 12: I'm not sure why you're setting $current_path. You could just use the below on line 14 if (path_is_admin(current_path())) {
Nothing else that the automated review didn't pick up
Other notes
I was able to test in IE 8 and 9 and FF and it seemed ok. You mention Chrome in your description - maybe some more cross browser testing and you can use for all 'modern' browsers.
While on Add content pages etc this is really useful (if you just want to edit a title etc. however it does this on pages with filters at the top as well, i.e /admin/content (attached image) - While not a major thing it seem odd to have the form submit buttons away from the filters (thought that could just be me - purely my opinion)
Comment #3
mikeendale commentedThanks for the review, Paul.
I have updated the errors the automated review picked up.
For your question about setting $current_path variable; it is generally accepted in the Drupal codebase to not assign a function within a function like (path_is_admin(current_path()). For instance, if you look at the core Overlay module line 131, you will see $current_path variable is set.
I have removed 'chrome' from the Readme.txt. I can see how it can be confused with Google Chrome.
Source: http://www.quora.com/Google-Chrome/Why-is-Chrome-called-Chrome
Comment #4
paul rowell commentedCheers for the clarification :)
Setting back to needs review
Comment #5
silbermann commentedManual review
The idea is good and helpful. But the module does not contain much code. This could be a problem. Look at point 2.3: Ensure your project contains a minimum of handwritten code on the page Project application checklist.
Another point: there exists a module named Util that contains some helpful features like printing administration buttons on the top of the page, too. Perhaps you can provide your idea to them to improve their module?
I don't see any problems with points 3 to 6 of the Project application checklist. But as I say, not much code to review.
I tested your module on IE 7, too. No problems.
Kind regards
Comment #6
stockunlocks commentedManual review
I've installed the module and it works just fine on (Mac):
It does everything it says it's supposed to do.
As far as the coding is concerned, it's true, there's not much code as the Project application checklist states (2.3):
However, it also states at the end of the same paragraph:
With that in mind, I see that you have another project in the sandbox: "OpenData Publisher". Maybe getting that one approved might pave the way for "Floating Buttons" if the amount of code is truly an issue. Just an idea.
Otherwise, everything worked well for me as stated above.
All the best
Comment #7
kscheirerPlease let us know how you'd like to proceed and set this issue back to "needs review".
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #8
gmclelland commentedFYI.. This looks very similar to https://drupal.org/project/sticky_edit_actions
Comment #9
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.