Initial support for system-wide tokens:

[locationmap:latitude]
[locationmap:longitude]

Useful for Location Map issue: #1825468: Integration with Meta Tags module - Drupal 7


Working OK for adding custom (geo) meta tags from metatag module.
Related issue: #1278146: [META] Ensure all meta tags are supported (no patches, just planning)

CommentFileSizeAuthor
#1 locationmap--2072263--initial-token-support--1.patch1.9 KBamontero
locationmap--initial-token-support--0.patch1.82 KBamontero

Comments

amontero’s picture

amontero
Location Barcelona
commented
Issue summary: View changes

Linking issue

amontero’s picture

amontero
Location Barcelona
commented
Title: Initial support for system-wide tokens » Add Token module support for latitude and longitude
StatusFileSize
new locationmap--2072263--initial-token-support--1.patch1.9 KB

Added descriptions to get rid of status page warnings.

amontero’s picture

amontero
Location Barcelona
commented
Issue summary: View changes

Edit

babbage’s picture

babbage commented
Issue summary: View changes

Sounds like a suitable idea for a patch. For future reference, this should have been posted to #1825468: Integration with Meta Tags module - Drupal 7 rather than creating a new issue, since it directly addresses the issue raised in that thread. Given other extreme commitments, may be a little while before I can test this, though I am not the only person with commit rights here so this may happen sooner. :)

Edit: Oh, ok, perhaps what you're saying is that Token support is necessary but not sufficient for Meta Tags support? In that case, perhaps a separate issue was indeed correct. My bad. :)

amontero’s picture

amontero
Location Barcelona
commented
Parent issue: » #1825468: Integration with Meta Tags module - Drupal 7

Hi babbage.
Thanks for your feedback. Even if you could not test the patch, did you review the code?
Is there anything else needed to get this commited? (apart from third party testing)
TIA.

rupertj’s picture

rupertj commented
Status: Needs review » Closed (fixed)

Thanks - Looks good to me, so I've committed it. The only thing I did change was the wording that appears in the token UI. IE: "Location Map Tokens" => "Location map" to match the case & style of the other options, and "Latitude" => "Latitude of map marker." just for a bit more information.

amontero’s picture

amontero
Location Barcelona
commented

Checklist: worth mentioning in module's project page?