[D7] Mapping Leaflet

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Maybe you are included in the module css file with the following code?

.leaflet-top, .leaflet-bottom {
    z-index: 500 !important;
}

The problem: Css in the Leaflet library(leaflet.css) displays a buttons and copyrights on the map with the z-index: 1000. It will create problems to the site administrators, who using the overlay layers. Because the overlay in Drupal output use z-index: 500, and a buttons and copyrights will appear above the administrative interface.

It looks good now. In my opinion there is no more problems.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/theme/mapping_leaflet.css
  --------------------------------------------------------------------------------
  FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
  --------------------------------------------------------------------------------
   7 | ERROR | Multiple selectors should each be on a single line
   8 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• project page must list the exact differences to the existing leaflet module so that users can make an educated decision which module to use.

Thanks for your contribution, Mac_Weber!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.