[D7] Nice Taxonomy Menu

Can you provide a link to the sandbox?

Link to the project page and git clone command are missing in the issue summary, please add them.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Looks like this is missing the project page link:
https://drupal.org/sandbox/gianfrasoft/2080639

And the git link:
git clone http://git.drupal.org/sandbox/gianfrasoft/2080639.git nice_taxonomy_menu

A couple things I see:

- you'll want an .install to do a hook_uninstall(). You need to add variable_del('ntm-count');
- then cycle through that count and do variable_del('ntm-node-type-' . $i);
- line 80, 89, and 102 you need a default for variable_get
- for hook_menu and hook_permission you need to indicate they are hooks. IE -

/**
  * Implements hook_menu().
  */

- add a doc comment for some custom functions like nice_taxonomy_menu_callback().

Also you need a README.txt file.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgianfrasoft2080639git

I'm a robot and this is an automated message from Project Applications Scraper.

Please fix it https://drupal.org/node/2080721#comment-7825387.
After that, status of the issue will be changed to "Needs review".

I upped the priority for you, if another 2 weeks goes by you can set it to 'critical'. The best thing you can do is get a Review Bonus by reviewing other applications. That will get you to the top of the list of projects to get reviewed (and hopefully approved). Only manual reviews count, just using http://pareview.sh is not enough.

----
Top Shelf Modules - Crafted, Curated, Contributed.

A view things I've noticed browsing quickly through your code:

• A lot of the commenting is in Italian. Please translate these to English so we can read them.
• You use 'und' when you get a value from a field, e.g. on line 312. You should use LANGUAGE_NONE or something like field_view_value().
• You are setting a couple of variables on your admin page. When the module is uninstalled, these variables need to be removed. Add a .install file and a variable_del().
• You git link in the description above does not work.

Hope this helps.

After review the status goes back to normal.

----
Top Shelf Modules - Crafted, Curated, Contributed.

added links

Automated review:

pareview.sh doesn't show any issues.

Manual review:

1. The GIT link in your issue summary points to the maintainer version of the repository. Please change it to point to the non-maintainer version.
2. All variables set are prefixed with module name ntm%. If you have more variables set in the module, you could do something (in your hook_uninstall()) like the following to ensure that you don't miss deleting any variables:

   db_delete('variable')
     ->condition('name', 'ntm%', 'LIKE')
     ->execute();
   

   Just a thought.

3. Its good to know that you are aware of the hook_update_N. Very rare in this issue queue.
4. The function nice_taxonomy_menu_has_son could be renamed to nice_taxonomy_menu_has_child, as it is how taxonomy menus are referred to in the community (not a rule of thumb though). Not a blocker.
5. Looks like in and after function nice_taxonomy_menu_contents, you are using some foreign language (Italian according to the Google translator), to comment your code. While using more inline comments is very good, we have to make sure that the mass of the users understand it. English is (and should be) used any sort of documentation on drupal.org

Thank you for making the changes. But, looks like you've removed the inline comments altogether. It would be very helpful if you translate them to English. Not a blocker though.

Whenever, you've done making the changes requested the status of the issue should be changed to "needs review".

Hello,

in your module uninstall function you use a query to remove variables, but I think it is better to use "variable_del".

I understand it is one line vs multiple lines, but I believe the use of API is recommended over the custom code. Plus, the function clears the variable cache.

Thanks,
V.

@centas, that's a valid point, but not a blocking issue.

@kscheirer, I see, my bad. Will keep in mind next time.

Updated links

So it looks like some git administrator has already approved your account. Please tell them to got through the official channel here next time, so that we can coordinate our effort in reviewing applicants better.

Thanks for your contribution, gianfrasoft!

Somebody updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

@gianfrasoft - I think I know what happened. You already got a project approved:
https://drupal.org/node/1468596

You don't actually have to go through this process to promote other modules. The project application process is really a "vetting" process, once it's proven that you can do one moderately sized module up to coding standards, you can then be trusted to do the same will all future modules of yours.