[D7] South African ID

Hi, webwarrior

Please Moving from a master to a major version branch.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxwebwarrior1861084git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi webwarrior!
Review results:

1. Project page is too short, see https://drupal.org/node/997024
2. Wrong link to your application a repository project (https://drupal.org/node/1587704)
3. You must use PHP wrapper functions (https://api.drupal.org/api/drupal/includes%21common.inc/group/php_wrappe...) instead if (strlen($id) <> 13) { (southafrican_id.module 123 line)

4. Code too simple

   This project does not demonstrate sufficient hook usage and/or API integration, therefore it is only eligible for a one-time promotion to a full project. You can find more info at Working with the Drupal API.

   This is an important criterion so that code integrates well and can be improved over time. I encourage you to continue developing and gaining from the feedback available in the git approval process.

   Thank you for you contributions and understanding.

I'm ok with the size, while it is on the short side, the module provides a complete field implementation in addition to a custom checksum function. No problems found.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Updated issue summary.

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

Thanks for your contribution, webwarrior!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.