This is a HDFC payment payment gateway module used for the payment processing on Drupal commerce enabled sites. We have worked closely with HDFC guys to come up with this module andhave successfully implemented in 2 of our live projects already for past 2 months. We have also created a demo site to just test this module: http://myndsets.in/commerce_kickstart2.

You can download a copy of our project from here: git clone http://git.drupal.org/sandbox/pvinayv/2087547.git

Here's the sandbox page we created: https://drupal.org/sandbox/pvinayv/2087547

Comments

Vinay Punyamurthy’s picture

Title: [D8] Commerce HDFC Payment Gateway » [D7] Commerce HDFC Payment Gateway

I've changed the title of this issue as I had mistakenly entered the module version as [D8]. It is actually [D7] module!

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxpvinayv2087547git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

kscheirer’s picture

Priority: Major » Normal

Just cleaning up issue priorities, anything in "needs work" is not major.

thsths’s picture

Hi Vinay ,

I want to integrate the HDFC payment Gate way With Drupal7 Commerce Module. I tried some references but it didn't worked.
Actually im not getting how to download "Commerce HDFC Payment Gateway" module from git.
Could you please explain how to use below string to download "Commerce HDFC Payment Gateway" module.

git clone http://git.drupal.org/sandbox/pvinayv/2087547.git commerce_hdfc_payment_gateway

Thanks.

Vinay Punyamurthy’s picture

Dear thsths,

You can download from git using this url: git clone http://git.drupal.org/sandbox/pvinayv/2087547.git

You will need a git client to download files!

Vinay Punyamurthy’s picture

Issue summary: View changes

Changed few files

Vinay Punyamurthy’s picture

Status: Needs work » Needs review

Thanks @kscheirer

Cleaned up all the pending issues and have tested it on our demo site.

Please review and let know.

PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/2119647

Project 2: https://drupal.org/node/2091715

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Binu Varghese’s picture

Status: Closed (duplicate) » Needs review

Multiple Applications with [D7] Royal Olive.. Marked that as closed (duplicate) for the time being and reopening this one..

Please review..

Vinay Punyamurthy’s picture

Please review this module as the other project is removed from the application list.

Vinay Punyamurthy’s picture

Issue summary: View changes

Clearing text content

kscheirer’s picture

Issue summary: View changes
Status: Needs review » Needs work
Issue tags: -Commerce HDFC Payment Gateway +Commerce (duplicate)
Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
  • You have many code style issues reported here: http://pareview.sh/pareview/httpgitdrupalorgsandboxpvinayv2087547git, please resolve as many of those as possible.
  • Your repo should not have a commerce_hdfc directory, please move all files up one level and remove that.
  • Instead of inserting a single row of configuration data into the database on install, please make use of Drupal's variable system for storing config. This blog post goes into more detail.
  • Please refactor the files in includes/ to use the Commerce API. We don't allow executable php outside of Drupal. You can turn this into some class files if you like, or use hook_menu to register a particular url and perform PHP there.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Binu Varghese’s picture

Thanks @kscheirer
We shall be working on your suggestions..

Vinay Punyamurthy’s picture

Status: Needs work » Closed (duplicate)

We presently need sometime to fix the issues and hence, I'll mark this as closed till then

brahmjeet789’s picture

now is it working fine ?
as i check site http://myndsets.in/commerce_kickstart2 the payment for hdfc is working fine, for configuration of this module we may require the
Tranportal ID *
Tranportal Password *
Response IP Address 1 *
Response IP Address 2 *
Response IP Address 3 *
HDFC Purchase - Auth Request URL *
HDFC Dual Verification Request URL *
things from bank side ?

apaderno’s picture

Issue tags: -Commerce (duplicate)
Related issues: +#2119647: [D7] Royal Olive