Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Administrator of the site can create a page, and select blocks which will show on that page. After that admin can drag drop of any block in the page to change the position of block and also change the width and height of each and every block. Administrator can set default width and height of every block.
Project page link: https://drupal.org/sandbox/singh-nitin/2095529
Comment | File | Size | Author |
---|---|---|---|
#11 | drag-drop-blocks.png | 144.43 KB | davidmac |
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsingh-nitin2095529git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
nitinsingh CreditAttribution: nitinsingh commentedI have fixed the issues and also checked with the automated tool mentioned above.
Comment #3
batdesign CreditAttribution: batdesign commentedManual Review
This is a good module that worked on a fresh Drupal install. A few quick coding things.
Overall the module looks nice.
Comment #4
stockunlocks CreditAttribution: stockunlocks commentedVery nice and simple to put to use immediately.
Drupal 7.23:
I was able to configure a page containing 4 blocks, one of which required permissions for certain included links (Navigation). Everything showed up as expected and I was able to re-size the blocks without any problem.
I tested viewing the results of the re-sizing in another browser, not logged in with the permission to make changes, and the results were observable.
However, I'm just having a little problem with the "drag and dropping". How is this accomplished? I thought that by simply clicking on a block and dragging would do it, but the block "snaps back" to its original location.
Maybe additional information may be provided in the README.txt if the drag/drop requires key combinations, etc.
All the best
Comment #5
davidmac CreditAttribution: davidmac commentedHi,
This looks like an interesting module. I have some initial observations.
Comment #5.0
davidmac CreditAttribution: davidmac commentedAdded project page link
Comment #6
nitinsingh CreditAttribution: nitinsingh commentedHi,
Please find my comments on each and every point
Comment #7
davidmac CreditAttribution: davidmac commentedPlease review the best practice guidelines. You should explain here, why this module doesn't duplicate exisiting functionality provided by other modules, including Panels (in-place-editor), Blocks, and jquery_drag_drop, among others. For your project to proceed, it should not duplicate existing functionality provided by other modules. Please be explanatory in your comparisons.
The configure link in your .info file is incorrect.
Regarding my comment #5:
can you please respond to No. 2 as you have left the access callback option in. Why can't you use the permissions system for this?
Perhaps you haven't explained fully the purpose of this module, it suggests that you can create a page and drag and drop blocks in a tiled arrangement. However, it doesn't work very well, and although you say in #7 above that,
this bypasses the theme system which already provides the styling and theming, which your module appears to override.
Please address all of the above in detail, thanks.
Comment #7.0
davidmac CreditAttribution: davidmac commentedProject page link changed to sandbox
Comment #8
nitinsingh CreditAttribution: nitinsingh commentedThis is not a duplicate module, as I mentioned in the description of module, by using this module admin can create multiple page and set the different blocks for this page, drag drop the inner content of the block and also admin can change the width and height of any block according to your page layout.
I have left access control - because if admin create a page and gives an url for that page so he/she can also manage the access of that page.
I have removed the background (grey) of block, I used this because admin will easily differentiate the blocks.
Comment #9
davidmac CreditAttribution: davidmac commentedI feel that you are reinventing existing functionality with the routing option, and if you were to objectively appraise the functionality of this module you might agree that it should not have been submitted in it's current form. Some of the problems are:
Regrettably, I have to say that this is a generally poor quality module which lifts content and blocks out of the styling provided by the theme system and messes up the overall styling in a very buggy manner. It also appears as if you are ignoring some problems reported in comments #4, #5 and #7.
I wouldn't encourage you to continue its development as it stands given that this module duplicates functionality available with other modules as pointed out above.
Comment #10
davidmac CreditAttribution: davidmac commentedsee above
Comment #11
davidmac CreditAttribution: davidmac commentedSee the attachment for an illustration of the problems mentioned (standard Drupal setup).
Comment #12
nitinsingh CreditAttribution: nitinsingh commentedCan you please check your admin settings for this? if height is not set as 'auto' only than this can happen.
Comment #13
davidmac CreditAttribution: davidmac commentedThe height is set at auto and the problem remains. With respect, it is your job to do all of this testing as developer, I've pointed out the problem, you should replicate it and fix it.
Another issue is the title in these custom pages, it is lost after the initial save when going back into edit an existing page, but remains when set a second time, looks like a form submit issue.
The height overlapping of blocks is only one issue. You have many issues to address BUT FIRST, you need to decide if you want to continue presenting this module given that it rehashes/duplicates existing features available in Drupal(menus/routing/pages, block placement), and other contributed modules (Panels in place editor, layout manager, jquery_drag_drop etc).
One of the first tasks when writing a module is to research if similar modules already exist and the links provided above contain advice in this respect.
Comment #14
PA robot CreditAttribution: PA robot commentedProject 1: https://drupal.org/node/2181337
Project 2: https://drupal.org/node/2095707
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #15
apaderno