[D7] Star voting

Link to the project page and git clone command are missing in the issue summary, please add them.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi drupal_dev007,

You are missing some key parts of a project application as described here https://drupal.org/node/1587704..

most important:

1.1 Ensure your application contains a repository and project page link.

I noticed you attached your module code to the issue description. You will need to create a sandbox project, using your drupal.org account, to store your code for the duration of the reviews...

here's a quick list

1. Create sandbox projects and include links to the project page and git repo in your issue description.
2. The issue name should reflect the relevant version of Drupal. So your issue should be named [D7] Voting Star.

I did a manual review of the code you posted above and here are a few things you can clean up:

a. Code does not follow drupal coding standards (https://drupal.org/coding-standards). You can use http://pareview.sh to check your code once you create the snadbox project or even download and install the coder module (https://drupal.org/project/coder) to test locally.

b. Consider using Behaviors (https://drupal.org/node/756722#behaviors) to include your javascript found in star_voting.js. This is the recommended method in the community.

Hi,
Your code doesn´t match with Drupal standards. You can check it online in http://pareview.sh/

You should add a Readme.txt file to your module https://drupal.org/node/447604

You are working over the master branch. Make sure to set the correct default branch: http://drupal.org/node/1659588 and then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

You should check if there are another modules with similar functionality, if this is the case you should explain your improvements.

Code:

The code is not indent and so far of Drupal standards

In your .tpl file you should pass a render element array not a string to the "function render()" or just write the html out of the php tag
https://api.drupal.org/api/drupal/includes!common.inc/function/render/7
https://drupal.org/node/933976
https://drupal.org/documentation/theme

You can take a look to "function menu_get_object"
https://api.drupal.org/api/drupal/includes!menu.inc/function/menu_get_ob...
Probably you could use it instead of your custom "function _get_current_node()"

You could try to figure out a cleaner way to write "function tar_voting_db_interact()" instead of return FALSE three times. It seems unnecessary.

You could make use of "function votingapi_select_results" instead of built your own query.

Hope this helps,

Regards!

Anything in needs work is not major.

Hey drupal_dev007,

Can you help clarify what the differences are between this and Fivestar? https://drupal.org/project/fivestar

Both allow you to add ratings to nodes (fivestar as a field to any entity). From the module guidelines:

Search for similar modules, and explain how your application is different.

This demonstrates that you have taken the time to look for existing solutions, and an awareness of Drupal's 'collaboration over competition' ethos.

If you do find existing modules which are similar or related to the functionality of your project (even if only in name), expect reviewers to suggest instead providing your module as a feature or patch to the existing project. Be sure you've read the information at this link, and include your reasoning for the 'new module' approach in your application.

Thanks!

To add home page url and git clone url.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.