[D7] Mirrors

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxnielsdefeyter2088997git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
Exports are Views Data Exports in CSV format and Imports are Feeds. That seems a great couple!
Hopefully this project goes through!
I like the idea very much.
Greetings, Martijn

Nice module for export/import config. Just did a manual review and here is my comments:

1.

  drupal_alter('entity_types', $entity_types);
  drupal_alter('field_types', $field_types);
  drupal_alter('property_types', $property_types);

Seems we are expecting hook_entity/field/property_types_alter() to alter this list? may be it is worth looking for hook_mirrors_entity/field/property_types_alter()?

2.

  $bundles = _mirrors_supported_bundles();
  $bundles = _mirrors_add_property_settings($bundles);
  $bundles = _mirrors_add_fields($bundles);

Seems we just get bundle and alter them with property and fields. Can we get argument by reference, if thats that case? So the above will become

  $bundles = _mirrors_supported_bundles();
  _mirrors_add_property_settings($bundles);
  _mirrors_add_fields($bundles);

and definition just change to:

 function _mirrors_add_property_settings(&$bundles) {
  ...
  // No need to return $buddles.
  }

 function _mirrors_add_fields(&$bundles) {
  ...
  // No need to return $buddles.
  }

3.

  return array(
    'Administer mirrors' => array(
      'title' => t('Administer mirrors'),
      'description' => t('Use mirrors export-views.'),
    ),
  );

as per hook_permission, the key always small case and title is human-readable. So this array will be:

  return array(
    'administer mirrors' => array(
      'title' => t('Administer mirrors'),
      'description' => t('Use mirrors export-views.'),
    ),
  );

4.

module_load_include('inc', 'mirrors', 'mirrors.defaults');
module_load_include('inc', 'mirrors', 'mirrors.feeds');
module_load_include('inc', 'mirrors', 'mirrors.views');

Is there anyway to load the includes on function level instead of module header? if it needs to be there, we can add them in .info files[] ?

5. field/list.inc is empty. Can we add definition, if there one otherwise delete this file?

6. all files inside fields directory has file docblock as 'Field Declarations'. Can we make them bit more specific about what that file contains?

Your hookable functions should be documented in a mirrors.api.php file, see https://drupal.org/coding-standards/docs#functions.

Ok, I have to admin I don't understand what this module does. It looks really cool! Can you explain a little more about what it does and why I would want to use it? I can't find any code problems.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Can you mention a little more about the use case for this module? Does it export/import the bundle definitions or the bundle content?

Based on the fact that there are no objections since #12,

Thanks for your contribution, nielsdefeyter!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Cool looking module, could save a ton of work!

Closing this application as its been fixed & respective account has been updated

No need to do that, fixed issues will close automatically after 2 weeks. This gives interested parties time to reactivate the issue if they see a problem with the fix and also allows time to see that a change has been made. See https://drupal.org/node/156119