When you do an availability search for say "Group size 3, Children 1" (using units per type configuration) then click "Search for availability".
and you then chose 1 unit the Persons default to the max (Eg 6) and children to 0.

Similarly, when you do the availability search for the same "Group size 3, Children 1" (using individual units display configuration) the search results display all units with the max persons specified and children set to 0.

is there a way for these to inherit from the availability search ?

Thanks

CommentFileSizeAuthor
#4 rooms-prepopulate-group-children-2113209.patch7.94 KBjwilson3

Comments

artatac’s picture

artatac commented

I have this working at www.bookpitches.co.uk but currently it gives errors if you choose more than 1 room. I will post a patch once this is sorted

1an_m’s picture

1an_m commented
Issue summary: View changes

Unless I misunderstand the issue, this appears to be related to #2013457: Group size not passed to commerce-line-item:rooms-booking-number-people. The patch posted there works for more than 1 room selected.

artatac’s picture

artatac commented

To clarify this is not about passing to commerce line item. This is about the group size/children that yo specify in the availability search being passed to the resulting booking form.
Currently, out of the box, Rooms lets you search for say
1room > group size 5 > children 3
and the room types available are then presented below.

You then choose the room type you want to book by altering the unit to 1 > once you do this you are asked (yet again) for the group total and the number of children. In my opinion this is an unfriendly system, as we have already told it this info in the availability search (or is it me?)
the intention of the patched version at www.bookpitches.co.uk is to add this ability but currently I get errors if the rooms/pitches in the search is set to more than 1.

Also should there not be consistency in how they are referred to eg - in the search you are asked to specify the number of rooms(pitches) you want then in the resulting booking form they are referred to as units?

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new rooms-prepopulate-group-children-2113209.patch7.94 KB

I've updated the issue summary to state that this bug rears its head both when configuration is set to display per-type basis and for individual rooms.

This problem space becomes much harder to solve when there are multiple units (each with different group size and children size) chosen on the availability search form, however solving the problem for the most simple case where there is just one unit, one group size, and one set of children is at least a step forward.

Here is a patch that I think might address this issue; it actually does handle some of the harder problem, but this really needs more thorough testing.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

Ronald, I've created a remote branch "2113209" in our DrupalRoomsModule repo for this issue containing the patch above. If you think what I have so far is enough to get into master, please merge!

ronald_istos’s picture

ronald_istos commented
Issue tags: +7.1
g.rocchini’s picture

g.rocchini commented

Hello,
the problem is still here, both with develop and stable version.

The patch posted from jwilson3 on 2013-12-06 give me some error when i run it 

File to patch: modules/rooms_booking_manager/rooms_booking_manager.module
patching file modules/rooms_booking_manager/rooms_booking_manager.module
Hunk #1 succeeded at 351 with fuzz 2 (offset -21 lines).
Hunk #2 succeeded at 366 (offset -17 lines).
Hunk #3 FAILED at 466.
Hunk #4 succeeded at 593 with fuzz 2 (offset 3 lines).
Hunk #5 succeeded at 618 with fuzz 2 (offset 6 lines).
Hunk #6 FAILED at 1081.
Hunk #7 FAILED at 1104.
Hunk #8 succeeded at 2559 with fuzz 2 (offset 162 lines).

Any idea about this problem? Any official solution?

g.rocchini’s picture

g.rocchini commented

Hello,
I apply manually the patch and the problem is solved for the reservation of 1 room
If you set more rooms in one search the problem is still here.

ronald_istos’s picture

ronald_istos commented
Issue tags: -7.1 +7.2

I think we need to better define the issues here.

There seem to be two separate problems:

1. A constraint satisfaction problem. If I am search for a room that can hold at least 3 with 1 being a child I should get anything that can satisfy this constraint. It seems Room does this.
2. A usability issue: Given that I defined this already in the initial search why do I need to do it again. And there are actually reasons that have to do with price updates. Seems this issue is dealing with the usability concerns - is that correct?

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Issue tags: +#d7ux

Agreed. This is an end-user front-end usability issue. I think there is room for lots of small improvements like this to streamline booking and checkout process for the most simple cases. I might start trying to tag some of these issues with '#d7ux'.