[D7] Commerce Checkout Register

Sounds like another good module to solve login issue on a shopping flow. Thanks for working on this. Here is some review comments:

1. Looks like you are working on master (default) branch. We have to use version specific branch. Please check [#1015226]
2. Seems we have only .info file. As per [#1011698] the project application should be created once we have working application in place. So please commit your module details and change the status to 'Needs review'

Looks like this needs work then? See https://drupal.org/node/532400

Thanks for your updates @Purushothaman C... Some more reviews:

1. http://drupalcode.org/sandbox/purushothaman.drupalgeeks/2115745.git/blob... - This will be added by ci script, you can remove it.
2. Few comments from automation tool: http://pareview.sh/pareview/httpgitdrupalorgsandboxpurushothamandrupalge...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Updated issue summary.

http://pareview.sh/pareview/httpgitdrupalorgsandboxpurushothamandrupalge... is still reporting an issue with this module's branch setup:

It appears you are working in the "7.x" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
The following git branches do not match the release branch pattern, you should remove/rename them. See http://drupal.org/node/1015226

Other than that, I've reviewed the code and it looks okay. Seems to be using the API correctly.

Hi Purushothaman Chinnadurai,

I've just installed your module and it does exactly as you've described. I found a couple of minor issues though:

• Although the module's .info file correctly categorises the module as 'Commerce (Contrib)', the upper case 'C' in 'Contrib' causes the module to be listed in its own fieldset on the module list page. Changing it to lower case will group it with other 'Commerce (contrib)' modules
• The comment for the function commerce_checkout_register_form_commerce_checkout_form_alter() is a bit misleading, the function doesn't actually appear to do what the comment says

All looks good to me apart from the above.

I have updated and moved the code changes for the listed issues on comment#9.

Yep, looks good to me.

removing review bonus tag, you did not do all manual reviews, you just repeated the output of an automated review tool. Make sure to read through the source code of the other projects and provide your feedback.

I have reviewed your module, and I have a few concerns. No offense setting this to "needs work". If you can answer my concern, feel free to set it back to "need review".

commerce_checkout_register_checkout_form_submit() register users without checking if the site administrator requires e-mail verification or even allows registrations without approval.

I think, even if you might loose functionality if the site is configured not to allow registration without admin approval that you should try to call user_register_submit() from commerce_checkout_register_checkout_form_submit() to allow the normal registration process to do it's job and send e-mail and so on.

Also, I don't see any e-mail validation at all? Does that happen somewhere else in the commerce system?

Hi everyone ! I have a question. How do I add custom fields in to registration form ? I need it to save the information from the input in the admin/people section. Any thoughts will be appreciated :)

@Purushothaman Chinnadurai I understand why the module is designed this way, and how that works best for the user/site. My question is really this:
If an admin has configured the site to require e-mail validation i don't believe your module should override this setting. At least not without waring.
If the administrator configures the site with no e-mail verification required, then your module will work as expected, even if it uses user_register_submit(), right?

If that is the case I would suggest you use that and rather instruct admins to disable email verification when enabling you module.

If that will not work for you, maybe a entry on the status report page reminding admins that user can register without e-mail verification. You can show this message depending on the site configuration.

This sounds like a feature that should live directly in the existing commerce_checkout_login project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the commerce_checkout_login issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

What do you mean by it does not work well? If you cannot reach the maintainer(s) please follow the abandoned project process.

EDIT: I think it would be helpful if you could create a patch against the commerce_checkout_login module.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.