Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Oct 2013 at 06:38 UTC
Updated:
24 Jul 2014 at 03:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
göran commentedComment #2
gregglesLooks reasonable to me. Are you working on a patch to fix this Göran? If so then the assigned field is right. If not then you should unassign yourself.
Comment #3
damienmckennaComment #4
damienmckennaComment #5
gregglesUnassigning as it seems like Göran is not working on this.
Comment #6
damienmckennaThis patch replaces the meta tag, updates the README.txt, and adds an update script to replace update existing records.
Comment #7
damienmckennaComment #9
damienmckennaComment #12
damienmckennaIt just needed a reroll.
Comment #13
damienmckennaThis is related to #2267501: Replace twitter:image with twitter:image:src in that both of them are renaming existing meta tags.
I've realized we have an API problem - any sites that exported their meta tag configurations, either through Features, Context, Panels or Views, will not be caught by the update script, and there's nothing in the API to make it use the old values until the configurations are resaved. I've added #2298337: Add structure in API for meta tags to replace others to handle this.
Comment #14
damienmckennaNeeds improvements per #2267501: Replace twitter:image with twitter:image:src.
Comment #15
damienmckennaUpdated to match the twitter:image patch.
Comment #16
damienmckennaI forgot part of the patch. Per the twitter:image tag change, this will still support sites that have the old value, those will be transparently displayed as the new meta tag until their configuration is updated.
Comment #18
damienmckennaCommitted.