Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Nov 2013 at 18:39 UTC
Updated:
9 Sep 2018 at 22:36 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
auworks commentedHi mate,
As per drupal guidelines your module should have a minimum of 120 lines of code or 5 functions before it could be reviewed.
Please refer to section 2.3 of this page https://drupal.org/node/1587704
Good luck
Cheers,
Ash
Comment #3
klausiWrong, of course we can review smaller modules, too. We just can't give the git vetted user role away on a short projects, but we can always promote it manually to a full projects and applicants can always come back to us when they have a new project for promotion.
I think I will just remove that paragraph from the review checklist, since that is by no means an application blocker.
Comment #4
ItangSanjana commented@ashishupadhayay, thanks for dropping by.
@klausi, thanks for clarifying.
Comment #5
imunk commentedwe wait for the module development for the city field mate....:) keep rock !
Comment #6
swarad07There is nothing significantly wrong that I can see in the code.
I have a question though, have you explored the possibility of adding a patch to the addressfield module ?
This module's functionality is similar to what the core module provides for US & UK. Just like the core module this module provides a select list of administrative areas & country specific labels for other address fields for Indonesia. Maybe your patch can be ported into the module ?
Please correct me if I got the purpose of this module wrong. As said earlier, there is nothing wrong I could see in the code. I will await feedback regarding the above concern.
Cheers,
Swarad
Comment #7
ItangSanjana commented@swarad07, yes I've tried to submit patch to addressfield here https://drupal.org/node/2129829.
But in the near future I am planning to implement a select list feature to the lowest level (village) in order to minimize typos in addressing.
I'm sure this will need to write a long page. Nevertheless if addressfield willing to accept such a long patch I would be happy :)
Thanks for the polite comments, looking forward to hear from you.
Tight handshake,
iS
Comment #8
klausiIf your patch is accepted please close this project application and feel free to come back to us whenever you have a new project to promote.
If your patch is rejected for whatever reason please revert the status of this project application and add a section to the issue summary where you explain why this could not go into addressfield core directly. And a link to the issue in the addressfield issue queue where that was discussed would be nice in the issue summary.
Comment #9
ItangSanjana commented@klausi, I'll let you know as soon as there is progress info. Thanks.
Comment #10
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #11
ItangSanjana commentedComment #12
PA robot commentedProject 1: https://www.drupal.org/node/2629388
Project 2: https://www.drupal.org/node/2130235
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #13
avpaderno